If required reviewer of the protected branch is specified as a group containing yourself and some other persons, OneDev will only add other person as reviewer for your own pull requests. Are you observing different behavior? If so, please attach screenshot of the branch protection setting.

Are you observing different behavior?

Nope - while creating it it is fine.

I investigated further:

• I was the only one in the group. So OneDev chose me
• But if there are other users I am still able to remove the other reviewers and add myself. That means I can trick the system to approve my own code changes. This is not good because I want a mandatory peer review.

This can be solved by requiring at least two reviewers from the group. For instance if review requirement is specified as group(reviewers):2, for any pull request pushing to protected branches, two persons from reviewer group will be required to approve it:

1. If the submitter is already a member of group reviewers, only one other reviewer is required as submitter already counts as a reviewer
2. If the submitter is not a member of group reviewers, two reviewers will be required

Okay. This is tricky ;)

Maybe it should be documented somewhere that the submitter counts as a reviewer?

Agreed that this is counter-intuitive. Will think about a less confusing approach...