#1178  LSIF support
Closed
Matthias Gramberg opened 1 year ago

Hi there :)

Do you know LSIF already?

The format hasn't changed since 3 years, so I guess its more stable than the version number suggests.

(Actually, I have an issue about that, here)

It enables stuff like this ??

I am specifically asking, since our language has global type inference and most types are actually shown in the editor, offline, and not online in Github or DevOne.

With LSIF, I can hover over the code and see its type, etc.

Do you have any interest, implementing that?

Nice greetings: ??

Robin Shen commented 1 year ago

This is something I will not do, as LSIF requires additional set up, and also it requires to pull out all sources to build the large index, which is time consuming and space inefficient. This means it is difficult or inefficient to use in practice. For instance, I checked GitLab's own repository, its code intelligence is not enabled:

https://gitlab.com/gitlab-org/gitlab-runner/-/blob/main/executors/docker/pull.go

While in OneDev, it is availalbe for artibrary commit instantly. Of course it is not as powerful/accurate as LSIF, but serves the purpose in most cases as a lightweight, ready to use code navigation help.

I also consider integrating vscode as a web ide for OneDev in future versions, and this makes LSIF support redundent.

Matthias Gramberg commented 1 year ago

Interesting. Does the current approach allow for type information that is not included in the source?

So can we see the inferred types?

Robin Shen commented 1 year ago

It can not do that. Only limits to symbols defined in source.

Matthias Gramberg commented 1 year ago

OK. Then I will close this with the outview for the VSCode integration.

Issue: https://code.onedev.io/onedev/server/~issues/952

Thanks a lot!

Matthias Gramberg changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
Matthias Gramberg commented 1 year ago

Solved

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
onedev/server#1178
Please wait...
Page is in error, reload to recover