#1160  File uploaded with Git LFS is corrupted on server side
Released
Máté Novak opened 1 year ago

Hi,

We have an issue with some zip files we uploaded to OneDev's remote repository using the Git LFS mechanism, which produced the cloning of the repository to fail. On the local end, the files seem to be properly uploaded but when we check them on the remote end, the size of the files is much less than expected, as if the file is written corrupted. Eventually, the issue was fixed by manually putting the files from the local repository to the server, using the file explorer tool and not git lfs push. In this case, the lfs objects were added with the expected size and cloning started to work again. But even with this fix, we are not able to use Git LFS which is highly important for our project. I appreciate any help or leads that can lead us to fix the issue.

Thanks.

Robin Shen commented 1 year ago

Is this reproducible? If yes, please provide relevant test files and sample repo.

Robin Shen commented 1 year ago

Did find same issue with a large file. Investigating...

Robin Shen changed fields 1 year ago
Name Previous Value Current Value
Priority
Normal
Major
Máté Novak commented 1 year ago

Ok, thanks. The files uploaded weren't that large, about 40 MB each.

I've tried to push from my local repository using:

git lfs push --object-id <remote> <oid>

If the lfs object's folder was under lfs/objects on remote, then the command did absolutely nothing, if I removed the folders manually from remote and then tried the command again, it show some progress and seemed to finish, but again size of file on remote was just wrong. What is interesting is that I tried this two or three times and the size on remote size was different each time.

We're using an elest.io instance to run OneDev, I tried to reproduce on my localhost but I couldn't, files were added correctly over there.

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed

Máté Novak commented 1 year ago

Hi there, is it planned to release a build with this fix anytime soon?

Thanks.

Robin Shen commented 1 year ago

The fix will be in 8.0 release, together with a lot of other improvements and bug fixes. I hope to get it out at mid this month.

Máté Novak commented 1 year ago

Thanks!

OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed
Released
OneDev commented 1 year ago

State changed as build #3440 is successful

Robin Shen commented 1 year ago

With 8.0, LFS upload will be much faster, and also corrupted upload will unlikely to happen any more even on unstable network. However existing corrupted uploads need to be removed, by removing the lfs folder from server, and push all objects again.

issue 1 of 1
Type
Bug
Priority
Major
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (4)
Reference
onedev/server#1160
Please wait...
Page is in error, reload to recover