Ability to change name in FROM header for service desk (OD-1140)
Closed
Stanislav N. opened 1 year ago

Currently it is always ~OneDev Notifier, which is inconvenient for service desk. Can per-project option for specifying name for FROM email header be added?

Robin Shen commented 1 year ago

OneDev uses this hard code name to reliably trims off quoted content from email body.

Stanislav N. commented 1 year ago

Should not be different for user specified name which is stored in database per project.

The only corner case I see is when administrator changed this name and reply with previous one is received.

Also, for HTML emails you can put comment in HTML code to reliably trim quoted text. Like:

<!-- cut here -->

Also it is a good practice to hardcode something like this to appear on top of message sent:

<!-- cut here -->
<hr>
<i>Please, put reply above the line, or otherwise it won't be processed</i>

REPLY FROM 1DEV GOES HERE.

> Quoted text from requester goes here.

And still cut using <!-- cut here -->.

Robin Shen commented 1 year ago

Email client will put the sender name automatically before quoted conent, thusly user no need to carefully put their reply inside special markers. This turns out to be very convenient.

Robin Shen commented 1 year ago

Also even if you use some line markers, when reply the email, the client will still generate sender info line above that:

On Jan 23, 2023, at 22:22, OneDev  <support@onedev.io> wrote:

<!-- cut here -->
<hr>
<i>Please, put reply above the line, or otherwise it won't be processed</i>

You still need to cut off the sender info line otherwise the reply is odd.

And if user specifies some common name for sender, it will be difficult to detect that line.

Robin Shen commented 1 year ago

Also I wonder why there is the need to change sender name. The project name is already shown in the issue title

Stanislav N. commented 1 year ago

Changing sender name is for:

  1. Hiding software info.
  2. Make correspondence look more client-oriented, e.g. by putting agent name answering in service desk ticket as name in FROM header. Like mails from Github - e.g. for Stanislav N. <notifications+blabla@github.com> you're talking not with random Github Notification, but with Stanislav N.
Andreas Mack commented 1 year ago

I agree with Stanislav. I had a co-worker ask me about "phishing" because he didn't recognize onedev.

Robin Shen changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
Stanislav N. commented 1 year ago

Why close?

Robin Shen commented 1 year ago

Using a custom sender name will not be supported due to reason outlined above.

Stanislav N. commented 1 year ago

Cutting MUA-added line is pretty simple I think, but depends on way we choose to implement it. For example, when custom hard coded line is used for FROM, it will be something like:

On Jan 23, 2023, at 22:22, My Super Project  <support+issue~1140@onedev.io> wrote:

Or even (for Evolution at least):

On Jan 23, 2023, at 22:22, My Super Project wrote:

If we choose to put user name instead of user agent:

On Jan 23, 2023, at 22:22, Stanislav N.  <support+issue~1140@onedev.io> wrote:
On Jan 23, 2023, at 22:22, Stanislav N. wrote: // Evolution style

Which can use following logic:

  • Try to find a line with issue id (issue~{ID}) which isn't quoted (with > or <quote> if HTML mail is used). If found - cut it.
  • Try to find hard coded string from project settings which isn't quoted (with > or <quote> if HTML mail is used). If found - cut it.
  • Try to find user name of one of users that participating in discussion which isn't quoted (with > or <quote> if HTML mail is used). If found - cut it.

I understand that this might not be easy to implement as I just wrote it, yet I'm asking to at least reopen this issue. Someone might provide a patch for it (maybe even me, but later).

Robin Shen changed state to 'Open' 1 year ago
Previous Value Current Value
Closed
Open
Robin Shen commented 1 year ago

OK. Will make the FROM customizable. However be careful to make it unique enough to avoid cutting off real content.

Robin Shen commented 1 year ago

The FROM header will be something like this: Robin Shen [OneDev]. The user name is automatically taken from the user commented the issue. This way the mail is more user friendly and can also serve the purpose of reliably cutting off quotations.

Robin Shen commented 1 year ago

The improvement will be covered in issue #1209

Robin Shen changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (5)
Reference
OD-1140
Please wait...
Page is in error, reload to recover