Stanislav N. opened 1 year ago
|
|||||
OneDev uses this hard code name to reliably trims off quoted content from email body. |
|||||
Should not be different for user specified name which is stored in database per project. The only corner case I see is when administrator changed this name and reply with previous one is received. Also, for HTML emails you can put comment in HTML code to reliably trim quoted text. Like:
Also it is a good practice to hardcode something like this to appear on top of message sent:
And still cut using |
|||||
Email client will put the sender name automatically before quoted conent, thusly user no need to carefully put their reply inside special markers. This turns out to be very convenient. |
|||||
Also even if you use some line markers, when reply the email, the client will still generate sender info line above that:
You still need to cut off the sender info line otherwise the reply is odd. And if user specifies some common name for sender, it will be difficult to detect that line. |
|||||
Also I wonder why there is the need to change sender name. The project name is already shown in the issue title |
|||||
Changing sender name is for:
|
|||||
I agree with Stanislav. I had a co-worker ask me about "phishing" because he didn't recognize onedev. |
|||||
Robin Shen changed state to 'Closed' 1 year ago
|
|||||
Why close? |
|||||
Using a custom sender name will not be supported due to reason outlined above. |
|||||
Cutting MUA-added line is pretty simple I think, but depends on way we choose to implement it. For example, when custom hard coded line is used for FROM, it will be something like:
Or even (for Evolution at least):
If we choose to put user name instead of user agent:
Which can use following logic:
I understand that this might not be easy to implement as I just wrote it, yet I'm asking to at least reopen this issue. Someone might provide a patch for it (maybe even me, but later). |
|||||
Robin Shen changed state to 'Open' 1 year ago
|
|||||
OK. Will make the FROM customizable. However be careful to make it unique enough to avoid cutting off real content. |
|||||
The FROM header will be something like this: |
|||||
The improvement will be covered in issue #1209 |
|||||
Robin Shen changed state to 'Closed' 1 year ago
|
Type |
Improvement
|
Priority |
Normal
|
Assignee |
Currently it is always
~OneDev Notifier
, which is inconvenient for service desk. Can per-project option for specifying name for FROM email header be added?