Allow to set auto merge for PRs (OD-1068)
Prabir Shrestha opened 3 years ago

AzureDevops has the capability to auto complete a PR if the CI build is successful and can merge/squash. Would be good if onedev adds support for it. If others want to comment the can cancel the autocomplete or keep the autocomplete and comment.

https://learn.microsoft.com/en-us/azure/devops/repos/git/pull-requests?view=azure-devops&tabs=browser image.png

  • Unknown commented 3 years ago

    @prabirshrestha The idea of Pull Requests are so that physical programmers can review the code before merging it, so I am unsure the use of this feature, just because something complies does not mean it doesn't contain logic issues, or vulnerabilities which a programmer would pick up during review.

    Personally I do not see the need for this feature, PR's should be reviewed and this removes the idea of PR's.

  • Robin Shen changed state to 'Closed' 3 years ago
    Previous Value Current Value
    Open
    Closed
  • Robin Shen changed state to 'Open' 3 years ago
    Previous Value Current Value
    Closed
    Open
  • Prabir Shrestha commented 3 years ago

    At work we have 300+ devs working on the same repro and I can't imagine how one would be able to live without this feature as there are high chances of having merge conflicts. There are settings one can apply to project such that if someone comments on autocomplete PRs, projects can set settings such that the same folks need to review before it can be signed off.

    For now I'm primarily using onedev for personal where I'm only the dev so it makes sense for me to set auto complete to most PRs and then checkin if my CI passes.

  • OneDev changed state to 'Closed' 1 year ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 1 year ago

    State changed as code fixing the issue is committed (d35f84ef)

  • OneDev changed state to 'Released' 1 year ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 1 year ago

    State changed as build OD-5739 is successful

  • Robin Shen changed title 1 year ago
    Previous Value Current Value
    Allow to set auto complete for PRs
    Allow to set auto merge for PRs
  • jbauer commented 1 year ago

    @robin If a squash merge strategy is chosen that uses the PR title and description as commit message AND the project has conventional commits enabled then it might be a good idea to check the PR title and description so that auto merge actually succeeds.

  • Robin Shen commented 1 year ago

    @jbauer I filed a bug for this: OD-2203

issue 1/1
Type
New Feature
Priority
Normal
Assignee
Issue Votes (0)
Watchers (5)
Reference
OD-1068
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover