I am afraid this may create too many caches if hash file changed frequently. I am not a node.js developer, but my understanding is that as long as there is a baseline node_moduels cache, running npm install to make it align with current package.json should be very fast.

I tried this and it didn’t work as npm install started to fail after few package updates. Seems like it may or may not work. Would be great to have multiple path hash as cache key.

I have of lot of space on my machine so size is not an issue.

How are you specifying the cache key?

I'm using the following: (I have two node_modules folder in the same project)

  caches:
  - key: '@project_name@-cargo-target'
    path: target
  - key: '@project_name@-root-node_modules'
    path: node_modules
  - key: '@project_name@-client-node_modules'
    path: client/node_modules

For each cache key, OneDev creates a separate cache, and then mounts that cache into specified path. It also makes sure that that particular cache is only used by one job run at the same time. However it maybe used by different job runs (or even different jobs if their cache key is the same) at different time. My understanding is that as long as npm install rans as the first command, that cache will be synced with the version specified in package.json even if some package has different versions (due to use in other jobs etc). I did some experiments when implementing the cache, and it seems so. Please correct me if I am wrong on this.