Can't build master branch (OD-1047)
Released
Unknown opened 1 year ago

Hello,

I attempted to build master branch so I am able to contribute but I keep getting a huge amount of failed tests when trying to compile server-core, am I missing something?

I have attached alog for you to view: build.log

Robin Shen commented 1 year ago

Some tests are committing to a test repository, and jgit checks local config and trys to sign the commit using your gpg key and it failed to do so due to unknown passphrase. For now, you may skip tests and go on. I will add some option later to disable commit sign in the test.

Unknown commented 1 year ago
Its been a long time since I have used maven, what cli argument to disable tests during the build?
Robin Shen commented 1 year ago
Unknown commented 1 year ago

This being a google search adds insult to injury xD

Thanks for the help though :)

Robin Shen commented 1 year ago

😉 will fix this soon though.

Unknown commented 1 year ago

@robin how do you prefer your contributions, pull request or patch file?

Also if I was to submit a patch would you run the tests on it (seen as nobody else other than you can right now)

Robin Shen commented 1 year ago

Pull request is preferred. Check this on how to submit a pull request:

https://docs.onedev.io/tutorials/code/fork-and-send-pullrequest/

There are not many unit tests now, and I normally check the funcitonality locally to see if it works as expected.

Unknown commented 1 year ago

Considering you are teaching me to make pull requests, I feel like you see me as a bad dev :/

Unknown commented 1 year ago

@robin I can't create a fork under my username, "do not have permission to create root project"

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed

Robin Shen commented 1 year ago

@polarian because sometimes it is not easy to find where to fork a repository in OneDev, as inquired by several users, I wrote a tutorial on how to do that.

Unknown commented 1 year ago

but how do I fork it if I do not have permission to do so?

Robin Shen commented 1 year ago

I can't create a fork under my username, "do not have permission to create root project"

Let me check this

OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed
Released
OneDev commented 1 year ago

State changed as build #3212 is successful

Robin Shen commented 1 year ago

@polarian should be working now.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (3)
Reference
OD-1047
Please wait...
Page is in error, reload to recover