andrzej opened 1 year ago
|
|||||
Can you please put that comment content in a file and attach here for my investigation? |
|||||
andrzej changed confidential 1 year ago
|
|||||
Here is an XML file that according to the logs failed to be imported. Please treat it as confidential information and destroy the file as soon as it is no longer needed. |
|||||
Yes will do. |
|||||
Below single comment exceeds 15000 characters. Not sure why this is happening. Can you find the original comment via OneDev web UI and compare to see if there is any differences? |
|||||
OneDev changed state to 'Closed' 1 year ago
|
|||||
State changed as code fixing the issue is committed |
|||||
Robin Shen changed confidential 1 year ago
|
|||||
Fixed the issue. Deleted all sensitive information and made this issue public in order to make it into release notes. |
|||||
OneDev changed state to 'Released' 1 year ago
|
|||||
State changed as build #3204 is successful |
|||||
andrzej changed state to 'Open' 1 year ago
|
|||||
Latest fix didn't solve the issue. During the upgrade from 7.6.0 (restored database of working version 7.6.0) failed to upgrade to newly released version 7.8.12 (with bugfix) with a following error:
|
|||||
Robin Shen changed confidential 1 year ago
|
|||||
OneDev changed state to 'Closed' 1 year ago
|
|||||
State changed as code fixing the issue is committed |
|||||
Robin Shen changed confidential 1 year ago
|
|||||
OneDev changed state to 'Released' 1 year ago
|
|||||
State changed as build #3207 is successful |
|||||
jewgeni changed state to 'Open' 1 year ago
|
|||||
Today I tried to upgrade 7.6.2 to 7.9.0, it didn't work. Also tried 7.8.16 and 7.7.15 It's always this: onedev-db | 2022-12-31 16:09:53.209 UTC [1] LOG: database system is ready to accept connections onedev-app | INFO - Launching application from '/app'... onedev-app | INFO - Starting server... onedev-app | ERROR - Error booting application onedev-app | com.google.inject.CreationException: Unable to create injector, see the following errors: onedev-app | onedev-app | 1) [Guice/ErrorInjectingConstructor]: NumberFormatException: For input string: "" onedev-app | at DefaultServerConfig.(DefaultServerConfig.java:54) onedev-app | at DefaultServerConfig.class(DefaultServerConfig.java:23) onedev-app | while locating DefaultServerConfig onedev-app | at DefaultClusterManager.(DefaultClusterManager.java:60) onedev-app | _ for 1st parameter onedev-app | at DefaultClusterManager.class(DefaultClusterManager.java:45) onedev-app | while locating DefaultClusterManager onedev-app | at DefaultSessionFactoryManager.(DefaultSessionFactoryManager.java:41) onedev-app | _ for 2nd parameter onedev-app | at DefaultSessionFactoryManager.class(DefaultSessionFactoryManager.java:41) onedev-app | while locating DefaultSessionFactoryManager onedev-app | at DefaultSessionManager.(DefaultSessionManager.java:61) onedev-app | _ for 3rd parameter onedev-app | at DefaultSessionManager.class(DefaultSessionManager.java:22) onedev-app | while locating DefaultSessionManager onedev-app | at DefaultTransactionManager.(DefaultTransactionManager.java:53) onedev-app | _ for 1st parameter onedev-app | at DefaultTransactionManager.class(DefaultTransactionManager.java:44) onedev-app | while locating DefaultTransactionManager onedev-app | at TransactionInterceptor.transactionManager(TransactionInterceptor.java:12) onedev-app | _ for field transactionManager Do you know how I can fix that? |
|||||
Please make sure property |
|||||
Thanks for the reply, it was already set. My server.properties:
|
|||||
I tried both docker installation and bare metal installation, and both of them can be upgraded from 7.6.2 to 7.9.0 without any issues. Can you please let me know how to get this reproduced? |
|||||
Robin Shen changed state to 'Closed' 1 year ago
|
|||||
Closed as can not be reproduced. Feel free to reopen if there is more clue. |
Type |
Bug
|
Priority |
Normal
|
Assignee | |
Affected Versions |
Not Found
|
Upgrade from running 7.6.0 to 7.7.0 or 7.8.8 (those two were tested) results in an upgrade failure, see following log entries:
INFO - >>> INFO - Creating tables... INFO - >>> INFO - Importing data into database... INFO - >>> INFO - Importing from data file 'Users.xml'... INFO - >>> INFO - Importing from data file 'Roles.xml'... INFO - >>> INFO - Importing from data file 'Projects.xml'... INFO - >>> INFO - Importing from data file 'UserAuthorizations.xml'... INFO - >>> INFO - Importing from data file 'Issues.xml'... INFO - >>> INFO - Importing from data file 'IssueComments.xml.3'... INFO - >>> INFO - Importing from data file 'IssueComments.xml'... INFO - >>> ERROR - Data truncation: Data too long for column 'o_content' at row 1 INFO - >>> ERROR - Error booting application INFO - >>> javax.persistence.PersistenceException: org.hibernate.exception.DataException: could not execute statement INFO - >>> at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:154) INFO - >>> at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:181) INFO - >>> at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:188) INFO - >>> at org.hibernate.internal.SessionImpl.doFlush(SessionImpl.java:1366) INFO - >>> at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1349) INFO - >>> at io.onedev.server.persistence.DefaultPersistManager.importData(DefaultPersistManager.java:492) INFO - >>> at io.onedev.server.persistence.SessionInterceptor$1.call(SessionInterceptor.java:23) INFO - >>> at io.onedev.server.persistence.DefaultSessionManager.call(DefaultSessionManager.java:85) INFO - >>> at io.onedev.server.persistence.SessionInterceptor.invoke(SessionInterceptor.java:18) INFO - >>> at io.onedev.server.maintenance.RestoreDatabase.doRestore(RestoreDatabase.java:106) INFO - >>> at io.onedev.server.maintenance.RestoreDatabase.start(RestoreDatabase.java:69) INFO - >>> at io.onedev.server.OneDev.start(OneDev.java:113) INFO - >>> at io.onedev.commons.loader.DefaultPluginManager.start(DefaultPluginManager.java:44) INFO - >>> at io.onedev.commons.loader.AppLoader.start(AppLoader.java:73) INFO - >>> at io.onedev.commons.bootstrap.Bootstrap.main(Bootstrap.java:189) INFO - >>> Caused by: org.hibernate.exception.DataException: could not execute statement INFO - >>> at org.hibernate.exception.internal.SQLExceptionTypeDelegate.convert(SQLExceptionTypeDelegate.java:52) INFO - >>> at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:42) INFO - >>> at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113) INFO - >>> at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:99) INFO - >>> at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:200) INFO - >>> at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3301) INFO - >>> at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3828) INFO - >>> at org.hibernate.action.internal.EntityInsertAction.execute(EntityInsertAction.java:107) INFO - >>> at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:604) INFO - >>> at org.hibernate.engine.spi.ActionQueue.lambda$executeActions$1(ActionQueue.java:478) INFO - >>> at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684) INFO - >>> at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:475) INFO - >>> at org.hibernate.event.internal.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:348) INFO - >>> at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:40) INFO - >>> at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:102) INFO - >>> at org.hibernate.internal.SessionImpl.doFlush(SessionImpl.java:1362) INFO - >>> ... 11 common frames omitted INFO - >>> Caused by: com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'o_content' at row 1 INFO - >>> at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:104) INFO - >>> at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:975) INFO - >>> at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1114) INFO - >>> at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1062) INFO - >>> at com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1383) INFO - >>> at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdate(ClientPreparedStatement.java:1047) INFO - >>> at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61) INFO - >>> at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java) INFO - >>> at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:197) INFO - >>> ... 22 common frames omitted ERROR - Failed to upgrade /opt/onedev
I've checked length of
o_content in
o_IssueComment` table and in both cases it is set to 15000.I wonder if this issue may be caused by XML fragments inlined in
content
field ofIssueComment
, ie. content was escaped during exporing data and then not unescaped during reimporting after schema upgrade.