#1010  If a pull request depends on a different pull requests both share commits which produces review noise
Closed
jbauer opened 1 year ago

Imagine you have

  • Branch A (forked off of main branch) with commits A, B, C
  • Branch B (forked off of branch A at commit C) with additional commits D, E, F

If you then create two pull requests, one for each branch, then pull request for branch A contains commits A, B, C and pull request for branch B contains commits A, B, C, D, E, F. So you end up with two pull requests sharing some commits. This creates quite some noise during review of pull request B in OneDev. This situation can for example happen if A, B, C implement a new feature and D, E, F, already use that new feature.

In other products (e.g. Gerrit) this situation is detected and if you look at pull request B you would only see changes of commits D, E, F and a note that this pull requests depends on pull request A. In that case you can not merge pull request B unless you have first merged pull request A. If pull request A is updated (commits added or commits replaced via force push or branch has only been rebased on main branch to keep it up to date) then pull request B needs to be rebased as well in order to be able to merge it.

Robin Shen commented 1 year ago

I will see this as an improvement rather than a bug

Robin Shen changed fields 1 year ago
Name Previous Value Current Value
Type
Bug
Improvement
Robin Shen changed state to 'Closed' 4 months ago
Previous Value Current Value
Open
Closed
Robin Shen commented 4 months ago

This will not be implemented due to added complexity and the rare use cases.

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
onedev/server#1010
Please wait...
Page is in error, reload to recover