Make OneDev 7.8 or higher compatible with old project urls (OD-1008)
Released
Robin Shen opened 1 year ago
No description
Robin Shen referenced from other issue 1 year ago
crash commented 1 year ago

Hi Robin, thanks for opening this issue :)

Please remember that (as far as I understand) the urls have (at least) two points of rewriting to be consistent, for instance:

/projects/id/action -> /projects/name/~action

or with a more concrete example:

https://onedev.local/projects/1/files/2d091e75c2b82893e27d541cc653ca0f4a69f4d5/make.sh?position=source-9.9-9.74-1 -> https://onedev.local/projects/prettyname/~files/2d091e75c2b82893e27d541cc653ca0f4a69f4d5/make.sh?position=source-9.9-9.74-1

Regarding the API I did a test and it seems to work as before, using just the project id (number). The only difference is to change the endpoint from /api to /~api, not a problem for my use case, but maybe it worths to make a rewrite rule also for that.

I think that’s all, but in case I will spot out some other corner case I will post it here :)

bye!

OneDev changed state to 'Closed' 1 year ago
Previous Value Current Value
Open
Closed
OneDev commented 1 year ago

State changed as code fixing the issue is committed

OneDev changed state to 'Released' 1 year ago
Previous Value Current Value
Closed
Released
OneDev commented 1 year ago

State changed as build #3152 is successful

Robin Shen commented 1 year ago

@crash 7.8.2 is fully compatible with old project urls, including the case you mentioned.

crash commented 1 year ago

I can confirm everything works as expected and I want to say that in almost 30 years of open source software I’ve never found a person so commited to the project and supersonic in solving any issue reported by the community.
Thank you Robin, very much indeed.

Robin Shen commented 1 year ago

Glad to be helpful. Fixing bugs and improving the user experience is my highest priority. Thanks for your feedback.

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (2)
Watchers (6)
Reference
OD-1008
Please wait...
Page is in error, reload to recover