|
Unknown opened 1 year ago
|
|
New commits added 1 year ago
|
|
|
Robin Shen merged 1 year ago
|
|
|
Thanks for merging this Robin :)
|
|
|
Yarn should stop complaining about this issue now (hopefully) |
|
|
Yes it won't. But we still need to commit yarn.lock to lock dependencies. |
|
|
I will add that |
|
|
Yeah I thought about doing this myself within the npm PR, but I felt it was outside the scope of the PR and would defeat the purpose, guess now you got to waste your time doing it... sorry... |
|
|
As for the other issues within issue #1, I will look into them and see if I can find a solution to them (it is not really a big deal, but its going to trigger me every time I build the docs for debugging if I do not fix it xD) |
|
|
No problem at all. The README.md is using yarn, but I am committing package-lock.json. This is really a bug. |
|
|
Yeah that is why I submitted this PR, it is highly recommended to NOT mish-mash package managers, and thus removing the package-lock.json would stop yarn from complaining (since it was the package manager you choose for the job) |
|
|
Yes, please go ahead to investigate, and I will be happy to merge the work. My impression is that modern javascript projects often have many warnings like this, as things are evolving quickly there, and often there are libraries abandoned by its maintainers. |
|
|
Yes, that is one of the many issues with javascript, every single day a
new library is brought out, look how many web frameworks javascript has,
all with their own pros and cons, and being updated so rapidly most
sites can't keep up.
Yes it is good to have fast development, but also it doesn't seem like javascript code is tested as robustly as other codebases, you don't see C codebases releasing massive changes every few days because it could cause severe security vulnerabilities. I might go ask the developers if they know why these warnings are being thrown, as it seems to be thrown by dependencies being resolved from docusaurus and not the dependencies you have named in the package. |
|
|
^^^ Also as seen above, email replies get a bit messy and I can't seem to figure out why... |
|
|
See there is no newlines in each paragraph so I do not see why it has been appended in the response here, maybe I should report this in onedev/server? |
|
|
What email client are you using? |
|
|
Thunderbird |
|
|
Yes, you may report this separately in onedev/server as a bug. |
|
|
Done, thanks for the help :) |
Npm lock file has been committed into the repository despite yarn being used as the package manager. This causes yarn to throw a warning outlined in issue #1