pull request approve buttons sequence ambigous (#1)

Matthias opened 6 years ago

To approve a pull-request you click on approve.
A text-entry field opens
below this text-entry field the buttons save and cancel appear
above this field the button approve is still active.

This is ambigous. If you enter text and press "approve", you are back to square one. There is no discernible difference between "cancel" (+"approve") and "approve" at this point. Depending on screen/font size the "save" button might be overlooked.

Suggested solution: once you click on "approve" the button dissapears or is clearly not active or changes to "save/cancel".

Activities

Robin Shen commented 6 years ago

This issue will be solved in the upcoming 3.2.0 release.

PS: please create issue for onedev in onedev-server project.
Robin Shen changed state to 'Closed' 6 years ago
Previous Value Current Value
Open

Closed
Robin Shen commented 6 years ago

This has now been fixed in 3.2.0:

https://code.onedev.io/projects/onedev-server/builds/797/artifacts
Login to comment

Previous Value	Current Value
Open	Closed

Type	Improvement
Priority	Minor
Assignee	Robin Shen

Issue Votes (0)

Watchers (2)

Reference

onedev/commons#1