Automatic escaping of characters in secret during git sync (OD-856)
Daniel Gollings opened 3 years ago

had a secret with character '/'

for example git push https://username:foo/[email protected]

This character needs to be escaped/encoded: https://stackoverflow.com/a/59284165

so it becomes git push https://username:foo%[email protected]

fixed it by encoding the character manually and storing that as a secret. But should be very simple to automate. If you point me as to the where I could submit a PR for a simple search&replace (although tbh there's probably some better Java native URL encoder that needs to be called just before running the action)

  • Robin Shen commented 3 years ago

    Thanks. I've fixed this at my side which is trivial.

  • Daniel Gollings commented 3 years ago

    figured as much, but thought I'd offer :)

  • OneDev changed state to 'Closed' 3 years ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 3 years ago

    State changed as code fixing the issue is committed

  • OneDev changed state to 'Released' 3 years ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 3 years ago

    State changed as build #2899 is successful

issue 1/1
Type
Bug
Priority
Normal
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (4)
Reference
OD-856
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover