Strip email signatures (OD-1109)

Unknown opened 3 years ago

Hello,

One issue with OneDev currently is I keep forgetting to strip my signature from my emails to [email protected], and it causes really weird formatting issues.

A signature is typically defined as:

At the bottom of the email

I sent the following in reply to issue #1107

I thought mainstream already is switching, I have read a lot of projects were moving...

Then again JVMs support backwards compatibility as far as I am aware, but Java 14 have some nice syntax improvements which I assume is why people updating.
-- 
Polarian
GPG signature: 0770E5312238C760
Website: https://polarian.dev
JID/XMPP: [email protected]

This produced the output:

The signature should ideally be stripped from emails, as it is not useful in the comments as you already have an account on OneDev (hopefully).

I am not sure you can use email reports without an account on OneDev, and this should be so because it prevents against spam issues as people must create accounts before using email based support.

Robin Shen commented 3 years ago

There is no reliable way to detect signature. For instance, on Mac mail, there is no '--' before signature. Also it is entirely possible to use '--' in the text.
Unknown commented 3 years ago

It has a specific format:

"-- \n" Is the conventional signature delimiter, if a client does not use this it is not conforming to conventions, which seems to be a common issue considering the last few issues I have submitted have been based on issues with conventions.

double "--" is not in the markdown format, and thus should have no conflict if filtered out.

The two things you need to make sure not to filter out is - for unordered lists and --- for horizontal rulings.

This will not conflict any other symbols within the format, and thus should not be an issue.

Apple is renown for breaking conventions, using proprietary formats, hardware etc, they are the definition of proprietary, so it is no surprise they do not follow conventions.
Unknown commented 3 years ago

Also as for using -- in text, it has to be in the format "-- \n" (space before the newline), if someone does this in the body of their email it is going to cause a lot more issues than you need to worry about.

If you are used to email you should know that "-- \n" is reserved for signatures and not to use it as a line separator, you can use --- or how many other - you want to separate paragraphs out, but double hyphen is specifically for signatures!

Polarian GPG signature: 0770E5312238C760 Website: https://polarian.dev JID/XMPP: [email protected]
Unknown commented 3 years ago

Oops I left the signature in... you see what I mean xD
OneDev changed state to 'Closed' 3 years ago
Previous Value Current Value
Open

Closed
OneDev commented 3 years ago

State changed as code fixing the issue is committed
OneDev changed state to 'Released' 3 years ago
Previous Value Current Value
Closed

Released
OneDev commented 3 years ago

State changed as build #3293 is successful
Login to comment

Previous Value	Current Value
Open	Closed

Previous Value	Current Value
Closed	Released

Type	Improvement
Priority	Normal
Assignee	Robin Shen

Issue Votes (0)

Watchers (3)

Reference

OD-1109

If you are used to email you should know that "-- \n" is reserved for signatures and not to use it as a line separator, you can use --- or how many other - you want to separate paragraphs out, but double hyphen is specifically for signatures!