Build sha256sums (OD-1098)
Unknown opened 3 years ago

Could you include the sha256sums of the files which are built, it would make packaging them a whole lot easier than pulling the build and calculating it myself just to then delete the build after :/

Thank you :)

  • Robin Shen commented 3 years ago

    No problem will do that later

  • Unknown commented 3 years ago

    Thanks, will be very useful :)

  • bufferUnderrun commented 3 years ago

    good feature

  • Unknown commented 3 years ago

    I thought you were against packaging?


  • bufferUnderrun commented 3 years ago

    It's not about packaging, it's about shasum and the way to check if download artifact is not corrupt.

  • Unknown commented 3 years ago

    It also makes my job easier when packaging

    Polarian GPG signature: 0770E5312238C760 Website: https://polarian.dev JID/XMPP: [email protected]

  • bufferUnderrun commented 3 years ago

    When i wrote "it's not about packaging", i answered to your previous question "I thought"...

  • OneDev changed state to 'Closed' 3 years ago
    Previous Value Current Value
    Open
    Closed
  • OneDev commented 3 years ago

    State changed as code fixing the issue is committed

  • Unknown commented 3 years ago

    Thanks for adding this Robin :)


  • OneDev changed state to 'Released' 3 years ago
    Previous Value Current Value
    Closed
    Released
  • OneDev commented 3 years ago

    State changed as build #3288 is successful

  • jbauer commented 3 years ago

    Would it make sense to name checksum files *.sha256 so it is clear which algorithm has been used to produce them?

    Maven for example also produces files *.jar.md5, *.jar.sha1, etc.

  • Unknown commented 3 years ago

    @robin Can't reopen issue and also it doesn't seem like the email reply I made has been posted... it has been a few minutes so it should have scraped it...

  • Unknown commented 3 years ago

    Jan 24 22:49:25 email postfix/smtp[1614]: 9D3A910A137D: to=<[email protected]>, relay=onedev-io.mail.protection.outlook.com[104.47.26.74]:25, delay=4.7, delays=0.14/0.03/2.1/2.4, dsn=2.6.0, status=sent (250 2.6.0 <[email protected]>

    It hit your microsoft relay, this is not an issue on my end...

  • Unknown commented 3 years ago

    Anyways seen as the email is not going to show up I may as well post it:

    Hello,
    
    I would have thought this would have been self explanatory, to use the algorithm as the file extension but it seems Robin has not done this.
    
    Robin you should ideally change this so that the file extension is the checksum algorithm you are using, for sha256 it should be <filename>.sha256 as suggested by Jbauer, thus I am going to reopen this issue! 
    
  • Robin Shen commented 3 years ago

    @polarian this is a bug, will fix it soon.

issue 1/1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (5)
Reference
OD-1098
Please wait...
Connection lost or session expired, reload to recover
Page is in error, reload to recover