#129  When click emojis in markdown editor, it takes a long time to show all emojis
Open
Robin Shen opened 11 months ago

This is because that these emojis are loaded one by one. It is better to put these emojis in a single image and then locate different emojis with positions in that image at client side.

Robin Shen changed fields 11 months ago
Name Previous Value Current Value
Assignee robin empty
Michael Weimann commented 11 months ago

Sounds like something for a front-end guy ;) I could have a look if you want.

Either using a sprite or maybe a more advanced emoji Picker.

Robin Shen commented 11 months ago
Robin Shen changed fields 11 months ago
Name Previous Value Current Value
Assignee empty mweimann
Michael Weimann commented 11 months ago

@robin what do you think of this one?: https://emoji-button.js.org/

It is an emoji picker written in plain JS with categories and a search function as well.

Robin Shen commented 11 months ago

I am fine with it. Does it support to input emoji via text? If not, what will the emoji look like in markdown source?

Michael Weimann commented 11 months ago

Does it support to input emoji via text? If not, what will the emoji look like in markdown source?

There are hooks for all type of events. My plan is just to swap the emoji selection "button" and keep all the rest like it is now.

Robin Shen commented 11 months ago

emoji +1

Andrea Del Bene commented 11 months ago

Hi,

I like the idea of integrating a specific library for emojis. I found another library that looks particularly light and easy to use, and it also has a clear documentation about unicode support:

http://onesignal.github.io/emoji-picker/demo/

Michael Weimann commented 11 months ago

Hey @andreaDelBene I also found emoji-picker during research.

I would try emoji button because if you have a look at emoji-picker Git activity and issue status it looks quite dead.

Andrea Del Bene commented 11 months ago

understood emoji +1 !

Referenced from pull request 11 months ago
Andrea Del Bene commented 11 months ago

Hi!

I've collected in PR a couple of ideas to improve current emojis solution:pull request #14. Hope this could help .

issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Milestone
No milestone
Issue Votes (0)
Watchers (3)
Reference
issue onedev-server#129
Please wait...
Page is in error, reload to recover