• 2024-03-09
  • Robin Shen committed 1 week ago
  • 2016-10-31
  • Merge tag 'spi-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
    Pull spi fixes from Mark Brown: "A few small fixes for SPI, one core fix
      that only applies in cases where we're handling DT overlays and a
      couple of driver specific fixes:
    
       - Fix handling of error cases when instantiating DT overlays so we
         don't end up just ignoring devices that encountered an error during
         instantiation.
    
       - Avoid reading uninitialized data when handing spurious interrupts
         in the espi driver.
    
       - A driver specific fix for the dspi driver to fix a bad interaction
         with u-boot"
    
    * tag 'spi-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
      spi: dspi: clear SPI_SR before enable interrupt
      spi: fsl-espi: avoid processing uninitalized data on error
      spi: mark device nodes only in case of successful instantiation
    Linus Torvalds committed 7 years ago
  • Merge tag 'regulator-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
    Pull regulator fix from Mark Brown:
     "Fix ramp_delay warnings for v4.9
    
      A new warning was introduced for missing information about the time
      that regulators take to power on in v4.9. This is in theory a real
      issue but for most practical regulators the communication overhead of
      talking to the device is greater than the ramp time so a lot of
      drivers don't set it and the warning is far too noisy without
      identifying practical issues.
    
      Just remove the warning for now"
    
    * tag 'regulator-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator:
      regulator: core: silence warning: "VDD1: ramp_delay not set"
    Linus Torvalds committed 7 years ago
  • Merge tag 'regmap-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
    Pull regmap fixes from Mark Brown:
     "A couple of small build fixes here, nothing major.
    
      The missing include is triggered in some configurations and the
      renaming of ret is defensive for the benefit of some drivers people
      are in the process of mainlining"
    
    * tag 'regmap-fix-v4.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
      regmap: Rename ret variable in regmap_read_poll_timeout
      regmap: include <linux/delay.h> from include/linux/regmap.h
    Linus Torvalds committed 7 years ago
  • Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
    Pull TPM fix from James Morris.
    
    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security:
      tpm: remove invalid min length check from tpm_do_selftest()
    Linus Torvalds committed 7 years ago
  • tpm: remove invalid min length check from tpm_do_selftest()
    Removal of this check was not properly amended to the original commit.
    
    Cc: stable@vger.kernel.org
    Fixes: 0c541332231e ("tpm: use tpm_pcr_read_dev() in tpm_do_selftest()")
    Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Signed-off-by: James Morris <james.l.morris@oracle.com>
    Jarkko Sakkinen committed with James Morris 7 years ago
  • Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm
    Pull ARM fixes from Russell King:
     "A fix for a regression on ARMv4T CPUs, and wiring up the new pkey
      syscalls for ARM"
    
    * 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm:
      ARM: wire up new pkey syscalls
      ARM: fix oops when using older ARMv4T CPUs
    Linus Torvalds committed 7 years ago
  • Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc
    Pull sparc fixes from David Miller:
     "Several sparc64 bug fixes here:
    
      1) Make the user copy routines on sparc64 return a properly accurate
         residual length when an exception occurs.
    
      2) We can get enormous kernel TLB range flush requests from vmalloc
         unmaps, so handle these more gracefully by doing full flushes
         instead of going page-by-page.
    
      3) Cope properly with negative branch offsets in sparc jump-label
         support, from James Clarke.
    
      4) Some old-style decl GCC warning fixups from Tobias Klauser"
    
    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
      sparc64: Handle extremely large kernel TLB range flushes more gracefully.
      sparc64: Fix illegal relative branches in hypervisor patched TLB cross-call code.
      sparc64: Fix instruction count in comment for __hypervisor_flush_tlb_pending.
      sparc64: Handle extremely large kernel TSB range flushes sanely.
      sparc: Handle negative offsets in arch_jump_label_transform
      sparc64: Fix illegal relative branches in hypervisor patched TLB code.
      sparc64: Delete now unused user copy fixup functions.
      sparc64: Delete now unused user copy assembler helpers.
      sparc64: Convert U3copy_{from,to}_user to accurate exception reporting.
      sparc64: Convert NG2copy_{from,to}_user to accurate exception reporting.
      sparc64: Convert NGcopy_{from,to}_user to accurate exception reporting.
      sparc64: Convert NG4copy_{from,to}_user to accurate exception reporting.
      sparc64: Convert U1copy_{from,to}_user to accurate exception reporting.
      sparc64: Convert GENcopy_{from,to}_user to accurate exception reporting.
      sparc64: Convert copy_in_user to accurate exception reporting.
      sparc64: Prepare to move to more saner user copy exception handling.
      sparc64: Delete __ret_efault.
      sparc32: Fix old style declaration GCC warnings
      sparc64: Fix old style declaration GCC warnings
      sparc64: Setup a scheduling domain for highest level cache.
    Linus Torvalds committed 7 years ago
  • 2016-10-30
  • Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
    Pull networking fixes from David Miller:
     "Lots of fixes, mostly drivers as is usually the case.
    
       1) Don't treat zero DMA address as invalid in vmxnet3, from Alexey
          Khoroshilov.
    
       2) Fix element timeouts in netfilter's nft_dynset, from Anders K.
          Pedersen.
    
       3) Don't put aead_req crypto struct on the stack in mac80211, from
          Ard Biesheuvel.
    
       4) Several uninitialized variable warning fixes from Arnd Bergmann.
    
       5) Fix memory leak in cxgb4, from Colin Ian King.
    
       6) Fix bpf handling of VLAN header push/pop, from Daniel Borkmann.
    
       7) Several VRF semantic fixes from David Ahern.
    
       8) Set skb->protocol properly in ip6_tnl_xmit(), from Eli Cooper.
    
       9) Socket needs to be locked in udp_disconnect(), from Eric Dumazet.
    
      10) Div-by-zero on 32-bit fix in mlx4 driver, from Eugenia Emantayev.
    
      11) Fix stale link state during failover in NCSCI driver, from Gavin
          Shan.
    
      12) Fix netdev lower adjacency list traversal, from Ido Schimmel.
    
      13) Propvide proper handle when emitting notifications of filter
          deletes, from Jamal Hadi Salim.
    
      14) Memory leaks and big-endian issues in rtl8xxxu, from Jes Sorensen.
    
      15) Fix DESYNC_FACTOR handling in ipv6, from Jiri Bohac.
    
      16) Several routing offload fixes in mlxsw driver, from Jiri Pirko.
    
      17) Fix broadcast sync problem in TIPC, from Jon Paul Maloy.
    
      18) Validate chunk len before using it in SCTP, from Marcelo Ricardo
          Leitner.
    
      19) Revert a netns locking change that causes regressions, from Paul
          Moore.
    
      20) Add recursion limit to GRO handling, from Sabrina Dubroca.
    
      21) GFP_KERNEL in irq context fix in ibmvnic, from Thomas Falcon.
    
      22) Avoid accessing stale vxlan/geneve socket in data path, from
          Pravin Shelar"
    
    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (189 commits)
      geneve: avoid using stale geneve socket.
      vxlan: avoid using stale vxlan socket.
      qede: Fix out-of-bound fastpath memory access
      net: phy: dp83848: add dp83822 PHY support
      enic: fix rq disable
      tipc: fix broadcast link synchronization problem
      ibmvnic: Fix missing brackets in init_sub_crq_irqs
      ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
      Revert "ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context"
      arch/powerpc: Update parameters for csum_tcpudp_magic & csum_tcpudp_nofold
      net/mlx4_en: Save slave ethtool stats command
      net/mlx4_en: Fix potential deadlock in port statistics flow
      net/mlx4: Fix firmware command timeout during interrupt test
      net/mlx4_core: Do not access comm channel if it has not yet been initialized
      net/mlx4_en: Fix panic during reboot
      net/mlx4_en: Process all completions in RX rings after port goes up
      net/mlx4_en: Resolve dividing by zero in 32-bit system
      net/mlx4_core: Change the default value of enable_qos
      net/mlx4_core: Avoid setting ports to auto when only one port type is supported
      net/mlx4_core: Fix the resource-type enum in res tracker to conform to FW spec
      ...
    Linus Torvalds committed 7 years ago
  • geneve: avoid using stale geneve socket.
    This patch is similar to earlier vxlan patch.
    Geneve device close operation frees geneve socket. This
    operation can race with geneve-xmit function which
    dereferences geneve socket. Following patch uses RCU
    mechanism to avoid this situation.
    
    Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
    Acked-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    pravin shelar committed with David S. Miller 7 years ago
  • vxlan: avoid using stale vxlan socket.
    When vxlan device is closed vxlan socket is freed. This
    operation can race with vxlan-xmit function which
    dereferences vxlan socket. Following patch uses RCU
    mechanism to avoid this situation.
    
    Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    pravin shelar committed with David S. Miller 7 years ago
  • qede: Fix out-of-bound fastpath memory access
    Driver allocates a shadow array for transmitted SKBs with X entries;
    That means valid indices are {0,...,X - 1}. [X == 8191]
    Problem is the driver also uses X as a mask for a
    producer/consumer in order to choose the right entry in the
    array which allows access to entry X which is out of bounds.
    
    To fix this, simply allocate X + 1 entries in the shadow array.
    
    Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Mintz, Yuval committed with David S. Miller 7 years ago
  • 2016-10-29
  • net: phy: dp83848: add dp83822 PHY support
    This PHY has a compatible register set with DP83848x so
    add support for it.
    
    Acked-by: Andrew F. Davis <afd@ti.com>
    Signed-off-by: Roger Quadros <rogerq@ti.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Roger Quadros committed with David S. Miller 7 years ago
  • enic: fix rq disable
    When MTU is changed from 9000 to 1500 while there is burst of inbound 9000
    bytes packets, adaptor sometimes delivers 9000 bytes packets to 1500 bytes
    buffers. This causes memory corruption and sometimes crash.
    
    This is because of a race condition in adaptor between "RQ disable"
    clearing descriptor mini-cache and mini-cache valid bit being set by
    completion of descriptor fetch. This can result in stale RQ desc being
    cached and used when packets arrive. In this case, the stale descriptor
    have old MTU value.
    
    Solution is to write RQ->disable twice. The first write will stop any
    further desc fetches, allowing the second disable to clear the mini-cache
    valid bit without danger of a race.
    
    Also, the check for rq->running becoming 0 after writing rq->enable to 0
    is not done properly. When incoming packets are flooding the interface,
    rq->running will pulse high for each dropped packet. Since the driver was
    waiting for 10us between each poll, it is possible to see rq->running = 1
    1000 times in a row, even though it is not actually stuck running.
    This results in false failure of vnic_rq_disable(). Fix is to try more
    than 1000 time without delay between polls to ensure we do not miss when
    running goes low.
    
    In old adaptors rq->enable needs to be re-written to 0 when posted_index
    is reset in vnic_rq_clean() in order to keep rq->prefetch_index in sync.
    
    Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  • tipc: fix broadcast link synchronization problem
    In commit 2d18ac4ba745 ("tipc: extend broadcast link initialization
    criteria") we tried to fix a problem with the initial synchronization
    of broadcast link acknowledge values. Unfortunately that solution is
    not sufficient to solve the issue.
    
    We have seen it happen that LINK_PROTOCOL/STATE packets with a valid
    non-zero unicast acknowledge number may bypass BCAST_PROTOCOL
    initialization, NAME_DISTRIBUTOR and other STATE packets with invalid
    broadcast acknowledge numbers, leading to premature opening of the
    broadcast link. When the bypassed packets finally arrive, they are
    inadvertently accepted, and the already correctly initialized
    acknowledge number in the broadcast receive link is overwritten by
    the invalid (zero) value of the said packets. After this the broadcast
    link goes stale.
    
    We now fix this by marking the packets where we know the acknowledge
    value is or may be invalid, and then ignoring the acks from those.
    
    To this purpose, we claim an unused bit in the header to indicate that
    the value is invalid. We set the bit to 1 in the initial BCAST_PROTOCOL
    synchronization packet and all initial ("bulk") NAME_DISTRIBUTOR
    packets, plus those LINK_PROTOCOL packets sent out before the broadcast
    links are fully synchronized.
    
    This minor protocol update is fully backwards compatible.
    
    Reported-by: John Thompson <thompa.atl@gmail.com>
    Tested-by: John Thompson <thompa.atl@gmail.com>
    Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Jon Paul Maloy committed with David S. Miller 7 years ago
  • ibmvnic: Fix missing brackets in init_sub_crq_irqs
    Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Thomas Falcon committed with David S. Miller 7 years ago
  • ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
    Schedule these XPORT event tasks in the shared workqueue
    so that IRQs are not freed in an interrupt context when
    sub-CRQs are released.
    
    Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Thomas Falcon committed with David S. Miller 7 years ago
  • Revert "ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context"
    This reverts commit 8d7533e5aaad1c94386a8101a36b0617987966b7.
    
    It introduced kbuild failures, new version coming.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    David S. Miller committed 7 years ago
  • Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue
    Jeff Kirsher says:
    
    ====================
    Intel Wired LAN Driver Updates 2016-10-27
    
    This series contains fixes to ixgbe and i40e.
    
    Emil fixes a NULL pointer dereference when a macvlan interface is brought
    up while the PF is still down.
    
    David root caused the original panic that was fixed by commit id
    (a036244c068612 "i40e: Fix kernel panic on enable/disable LLDP") and the
    fix was not quite correct, so removed the get_default_tc() and replaced
    it with a #define since there is only one TC supported as a default.
    
    Guilherme Piccoli fixes an issue where if we modprobe the driver module
    without enough MSI-X interrupts, then unload the module and reload it
    again, the kernel would crash.  So if we fail to allocate enough MSI-X
    interrupts, we should disable them since they were previously enabled.
    
    Huaibin Wang found that the order of the arguments for
    ndo_dflt_bridge_getlink() were in the correct order, so fix the order.
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    David S. Miller committed 7 years ago
  • arch/powerpc: Update parameters for csum_tcpudp_magic & csum_tcpudp_nofold
    Commit 01cfbad "ipv4: Update parameters for csum_tcpudp_magic to their
    original types" changed parameters for csum_tcpudp_magic and
    csum_tcpudp_nofold for many platforms but not for PowerPC.
    
    Fixes: 01cfbad "ipv4: Update parameters for csum_tcpudp_magic to their original types"
    Cc: Alexander Duyck <aduyck@mirantis.com>
    Signed-off-by: Ivan Vecera <ivecera@redhat.com>
    Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Ivan Vecera committed with David S. Miller 7 years ago
  • Linus Torvalds committed 7 years ago
  • Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
    Pull x86 bugfix from Thomas Gleixner:
     "A single bugfix for the recent changes related to registering the boot
      cpu when this has not happened before prefill_possible_map().
    
      The main problem with this change got fixed already, but we missed the
      case where the local APIC is not yet mapped, when prefill_possible_map()
      is invoked, so the registration of the boot cpu which has the APIC bit
      set in CPUID will explode.
    
      I should have seen that issue earlier, but all I can do now is feeling
      embarassed"
    
    * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
      x86/smpboot: Init apic mapping before usage
    Linus Torvalds committed 7 years ago
  • Merge branch 'mlx4-fixes'
    Tariq Toukan says:
    
    ====================
    mlx4 misc fixes for 4.9
    
    This patchset contains several bug fixes from the team to the
    mlx4 Eth and Core drivers.
    
    Series generated against net commit:
    ecc515d7238f 'sctp: fix the panic caused by route update'
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    David S. Miller committed 7 years ago
  • net/mlx4_en: Save slave ethtool stats command
    Following the previous patch, as an optimization, the slave will
    not even bother sending the DUMP_ETH_STATS command over the
    comm channel.
    
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Tariq Toukan committed with David S. Miller 7 years ago
  • net/mlx4_en: Fix potential deadlock in port statistics flow
    mlx4_en_DUMP_ETH_STATS took the *counter mutex* and then
    called the FW command, with WRAPPED attribute. As a result, the fw command
    is wrapped on the Hypervisor when it calls mlx4_en_DUMP_ETH_STATS.
    The FW command wrapper flow on the hypervisor takes the *slave_cmd_mutex*
    during processing.
    
    At the same time, a VF could be in the process of coming up, and could
    call mlx4_QUERY_FUNC_CAP.  On the hypervisor, the command flow takes the
    *slave_cmd_mutex*, then executes mlx4_QUERY_FUNC_CAP_wrapper.
    mlx4_QUERY_FUNC_CAP wrapper calls mlx4_get_default_counter_index(),
    which takes the *counter mutex*. DEADLOCK.
    
    The fix is that the DUMP_ETH_STATS fw command should be called with
    the NATIVE attribute, so that on the hypervisor, this command does not
    enter the wrapper flow.
    
    Since the Hypervisor no longer goes through the wrapper code, we also
    simply return 0 in mlx4_DUMP_ETH_STATS_wrapper (i.e.the function succeeds,
    but the returned data will be all zeroes).
    No need to test if it is the Hypervisor going through the wrapper.
    
    Fixes: f9baff509f8a ("mlx4_core: Add "native" argument to mlx4_cmd ...")
    Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Jack Morgenstein committed with David S. Miller 7 years ago
  • net/mlx4: Fix firmware command timeout during interrupt test
    Currently interrupt test that is part of ethtool selftest runs the
    check over all interrupt vectors of the device.
    In mlx4_en package part of interrupt vectors are uninitialized since
    mlx4_ib doesn't exist. This causes NOP FW command to time out.
    Change logic to test current port interrupt vectors only.
    
    Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Eugenia Emantayev committed with David S. Miller 7 years ago
  • net/mlx4_core: Do not access comm channel if it has not yet been initialized
    In the Hypervisor, there are several FW commands which are invoked
    before the comm channel is initialized (in mlx4_multi_func_init).
    These include MOD_STAT_CONFIG, QUERY_DEV_CAP, INIT_HCA, and others.
    
    If any of these commands fails, say with a timeout, the Hypervisor
    driver enters the internal error reset flow. In this flow, the driver
    attempts to notify all slaves via the comm channel that an internal error
    has occurred.
    
    Since the comm channel has not yet been initialized (i.e., mapped via
    ioremap), this will cause dereferencing a NULL pointer.
    
    To fix this, do not access the comm channel in the internal error flow
    if it has not yet been initialized.
    
    Fixes: 55ad359225b2 ("net/mlx4_core: Enable device recovery flow with SRIOV")
    Fixes: ab9c17a009ee ("mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet")
    Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Jack Morgenstein committed with David S. Miller 7 years ago
  • net/mlx4_en: Fix panic during reboot
    Fix a kernel panic that occurs as a result of an asynchronous event
    handled in roce_gid_mgmt:
    mlx4_en_get_drvinfo is called and accesses freed resources.
    
    This happens in a shutdown flow only, since pci device is destroyed
    while netdevice is still alive.
    
    Fixes: c27a02cd94d6 ("mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC")
    Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Eugenia Emantayev committed with David S. Miller 7 years ago
  • net/mlx4_en: Process all completions in RX rings after port goes up
    Currently there is a race between incoming traffic and
    initialization flow. HW is able to receive the packets
    after INIT_PORT is done and unicast steering is configured.
    Before we set priv->port_up NAPI is not scheduled and
    receive queues become full. Therefore we never get
    new interrupts about the completions.
    This issue could happen if running heavy traffic during
    bringing port up.
    The resolution is to schedule NAPI once port_up is set.
    If receive queues were full this will process all cqes
    and release them.
    
    Fixes: c27a02cd94d6 ("mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC")
    Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
    Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Erez Shitrit committed with David S. Miller 7 years ago
  • net/mlx4_en: Resolve dividing by zero in 32-bit system
    When doing roundup_pow_of_two for large enough number with
    bit 31, an overflow will occur and a value equal to 1 will
    be returned. In this case 1 will be subtracted from the return
    value and division by zero will be reached.
    
    Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency")
    Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Eugenia Emantayev committed with David S. Miller 7 years ago
  • net/mlx4_core: Change the default value of enable_qos
    Change the default status of quality of service back to disabled,
    as it hurts performance in some cases.
    
    Fixes: 38438f7c7e8c ("net/mlx4: Set enhanced QoS support by default when ...")
    Signed-off-by: Moshe Lazer <moshel@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Moshe Lazer committed with David S. Miller 7 years ago
  • net/mlx4_core: Avoid setting ports to auto when only one port type is supported
    When only one port type is supported, it should be read only.
    We reject changing requests, even to the auto sense mode.
    
    Fixes: 27bf91d6a0d5 ("mlx4_core: Add link type autosensing")
    Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
    Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Maor Gottlieb committed with David S. Miller 7 years ago
  • net/mlx4_core: Fix the resource-type enum in res tracker to conform to FW spec
    The resource type enum in the resource tracker was incorrect.
    RES_EQ was put in the position of RES_NPORT_ID (a FC resource).
    
    Since the remaining resources maintain their current values,
    and RES_EQ is not passed from slaves to the hypervisor in any
    FW command, this change affects only the hypervisor.
    Therefore, there is no backwards-compatibility issue.
    
    Fixes: 623ed84b1f95 ("mlx4_core: initial header-file changes for SRIOV support")
    Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
    Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Jack Morgenstein committed with David S. Miller 7 years ago
  • Merge tag 'upstream-4.9-rc3' of git://git.infradead.org/linux-ubifs
    Pull ubi/ubifs fixes from Richard Weinberger:
     "This contains fixes for issues in both UBI and UBIFS:
    
       - A regression wrt overlayfs, introduced in -rc2.
       - An UBI issue, found by Dan Carpenter's static checker"
    
    * tag 'upstream-4.9-rc3' of git://git.infradead.org/linux-ubifs:
      ubifs: Fix regression in ubifs_readdir()
      ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()
    Linus Torvalds committed 7 years ago
  • rds: debug messages are enabled by default
    rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
    This option cause the rds Makefile to add -DDEBUG to the rds gcc command
    line.
    
    When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by
    include/linux/dynamic_debug.h to decide if dynamic debug prints should
    be sent by default to the kernel log.
    
    rds should not enable this macro for production builds. rds dynamic
    debug work as expected follow this fix.
    
    Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
    Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
    Reviewed-by: Wengang Wang <wen.gang.wang@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    shamir rabinovitch committed with David S. Miller 7 years ago
  • Merge tag 'mac80211-for-davem-2016-10-27' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211
    Johannes Berg says:
    
    ====================
    Just two fixes:
     * a fix to process all events while suspending, so any
       potential calls into the driver are done before it is
       suspended
     * small markup fixes for the sphinx documentation conversion
       that's coming into the tree via the doc tree
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    David S. Miller committed 7 years ago
  • ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
    Schedule these XPORT event tasks in the shared workqueue
    so that IRQs are not freed in an interrupt context when
    sub-CRQs are released.
    
    Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Thomas Falcon committed with David S. Miller 7 years ago
  • net: mv643xx_eth: Fetch the phy connection type from DT
    The MAC is capable of RGMII mode and that is probably a more typical
    connection type than GMII today (eg it is used by Marvell Reference
    designs for several SOCs). Let DT users specify the standard
    
       phy-connection-type = "rgmii-id";
    
    On a phy node.
    
    Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Jason Gunthorpe committed with David S. Miller 7 years ago
  • Merge tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
    Pull ARM SoC fixes from Olof Johansson:
     "We haven't seen a whole lot of fixes for the first two weeks since the
      merge window, but here is the batch that we have at the moment.
    
      Nothing sticks out as particularly bad or scary, it's mostly a handful
      of smaller fixes to several platforms. The Uniphier reset controller
      changes could probably have been delayed to 4.10, but they're not
      scary and just plumbing up driver changes that went in during the
      merge window.
    
      We're also adding another maintainer to Marvell Berlin platforms, to
      help out when Sebastian is too busy. Yay teamwork!"
    
    * tag 'armsoc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc:
      ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031
      ARM: dts: vf610: fix IRQ flag of global timer
      ARM: imx: gpc: Fix the imx_gpc_genpd_init() error path
      ARM: imx: gpc: Initialize all power domains
      arm64: dts: Updated NAND DT properties for NS2 SVK
      arm64: dts: uniphier: change MIO node to SD control node
      ARM: dts: uniphier: change MIO node to SD control node
      reset: uniphier: rename MIO reset to SD reset for Pro5, PXs2, LD20 SoCs
      arm64: uniphier: select ARCH_HAS_RESET_CONTROLLER
      ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER
      arm64: dts: Add timer erratum property for LS2080A and LS1043A
      arm64: dts: rockchip: remove the abuse of keep-power-in-suspend
      ARM: multi_v7_defconfig: Enable Intel e1000e driver
      MAINTAINERS: add myself as Marvell berlin SoC maintainer
      bus: qcom-ebi2: depend on ARCH_QCOM or COMPILE_TEST
      ARM: dts: fix the SD card on the Snowball
      arm64: dts: rockchip: remove always-on and boot-on from vcc_sd
      arm64: dts: marvell: fix clocksource for CP110 master SPI0
      ARM: mvebu: Select corediv clk for all mvebu v7 SoC
    Linus Torvalds committed 7 years ago
  • Merge tag 'batadv-net-for-davem-20161026' of git://git.open-mesh.org/linux-merge
    Simon Wunderlich says:
    
    ====================
    Here are three batman-adv bugfix patches:
    
     - Fix RCU usage for neighbor list, by Sven Eckelmann
    
     - Fix BATADV_DBG_ALL loglevel to include TP Meter messages, by Sven Eckelmann
    
     - Fix possible splat when disabling an interface, by Linus Luessing
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    David S. Miller committed 7 years ago
  • Revert "hv_netvsc: report vmbus name in ethtool"
    This reverts commit e3f74b841d48
    ("hv_netvsc: report vmbus name in ethtool")'
    because of problem introduced by commit f9a56e5d6a0ba
    ("Drivers: hv: make VMBus bus ids persistent").
    This changed the format of the vmbus name and this new format is too
    long to fit in the bus_info field of ethtool.
    
    Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Stephen Hemminger committed with David S. Miller 7 years ago
  • packet: on direct_xmit, limit tso and csum to supported devices
    When transmitting on a packet socket with PACKET_VNET_HDR and
    PACKET_QDISC_BYPASS, validate device support for features requested
    in vnet_hdr.
    
    Drop TSO packets sent to devices that do not support TSO or have the
    feature disabled. Note that the latter currently do process those
    packets correctly, regardless of not advertising the feature.
    
    Because of SKB_GSO_DODGY, it is not sufficient to test device features
    with netif_needs_gso. Full validate_xmit_skb is needed.
    
    Switch to software checksum for non-TSO packets that request checksum
    offload if that device feature is unsupported or disabled. Note that
    similar to the TSO case, device drivers may perform checksum offload
    correctly even when not advertising it.
    
    When switching to software checksum, packets hit skb_checksum_help,
    which has two BUG_ON checksum not in linear segment. Packet sockets
    always allocate at least up to csum_start + csum_off + 2 as linear.
    
    Tested by running github.com/wdebruij/kerneltools/psock_txring_vnet.c
    
      ethtool -K eth0 tso off tx on
      psock_txring_vnet -d $dst -s $src -i eth0 -l 2000 -n 1 -q -v
      psock_txring_vnet -d $dst -s $src -i eth0 -l 2000 -n 1 -q -v -N
    
      ethtool -K eth0 tx off
      psock_txring_vnet -d $dst -s $src -i eth0 -l 1000 -n 1 -q -v -G
      psock_txring_vnet -d $dst -s $src -i eth0 -l 1000 -n 1 -q -v -G -N
    
    v2:
      - add EXPORT_SYMBOL_GPL(validate_xmit_skb_list)
    
    Fixes: d346a3fae3ff ("packet: introduce PACKET_QDISC_BYPASS socket option")
    Signed-off-by: Willem de Bruijn <willemb@google.com>
    Acked-by: Eric Dumazet <edumazet@google.com>
    Acked-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Willem de Bruijn committed with David S. Miller 7 years ago
  • net_sched actions: use nla_parse_nested()
    Use nla_parse_nested instead of open-coding the call to
    nla_parse() with the attribute data/len.
    
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Johannes Berg committed with David S. Miller 7 years ago
  • cxgb4: Fix error handling in alloc_uld_rxqs().
    Fix to release resources properly in error handling path of
    alloc_uld_rxqs(), This patch also removes unwanted arguments
    and avoids calling the same function twice.
    
    Fixes: 94cdb8bb993a (cxgb4: Add support for dynamic allocation
           of resources for ULD
    Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Ganesh Goudar committed with David S. Miller 7 years ago
  • IB/mlx4: avoid a -Wmaybe-uninitialize warning
    There is an old warning about mlx4_SW2HW_EQ_wrapper on x86:
    
    ethernet/mellanox/mlx4/resource_tracker.c: In function ‘mlx4_SW2HW_EQ_wrapper’:
    ethernet/mellanox/mlx4/resource_tracker.c:3071:10: error: ‘eq’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    The problem here is that gcc won't track the state of the variable
    across a spin_unlock. Moving the assignment out of the lock is
    safe here and avoids the warning.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Arnd Bergmann committed with David S. Miller 7 years ago
  • spi: dspi: clear SPI_SR before enable interrupt
    Once dspi is used in uboot, the SPI_SR have been set by some value.
    At this time, if kernel enable the interrupt before clear the
    status flag, that will trigger the wrong interrupt.
    
    Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Yuan Yao committed with Mark Brown 7 years ago
  • ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()
    This patch updates skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit() when an
    IPv6 header is installed to a socket buffer.
    
    This is not a cosmetic change.  Without updating this value, GSO packets
    transmitted through an ipip6 tunnel have the protocol of ETH_P_IP and
    skb_mac_gso_segment() will attempt to call gso_segment() for IPv4,
    which results in the packets being dropped.
    
    Fixes: b8921ca83eed ("ip4ip6: Support for GSO/GRO")
    Signed-off-by: Eli Cooper <elicooper@gmx.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Eli Cooper committed with David S. Miller 7 years ago
  • bpf: fix samples to add fake KBUILD_MODNAME
    Some of the sample files are causing issues when they are loaded with tc
    and cls_bpf, meaning tc bails out while trying to parse the resulting ELF
    file as program/map/etc sections are not present, which can be easily
    spotted with readelf(1).
    
    Currently, BPF samples are including some of the kernel headers and mid
    term we should change them to refrain from this, really. When dynamic
    debugging is enabled, we bail out due to undeclared KBUILD_MODNAME, which
    is easily overlooked in the build as clang spills this along with other
    noisy warnings from various header includes, and llc still generates an
    ELF file with mentioned characteristics. For just playing around with BPF
    examples, this can be a bit of a hurdle to take.
    
    Just add a fake KBUILD_MODNAME as a band-aid to fix the issue, same is
    done in xdp*_kern samples already.
    
    Fixes: 65d472fb007d ("samples/bpf: add 'pointer to packet' tests")
    Fixes: 6afb1e28b859 ("samples/bpf: Add tunnel set/get tests.")
    Fixes: a3f74617340b ("cgroup: bpf: Add an example to do cgroup checking in BPF")
    Reported-by: Chandrasekar Kannan <ckannan@console.to>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Acked-by: Alexei Starovoitov <ast@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Daniel Borkmann committed with David S. Miller 7 years ago
Please wait...
Page is in error, reload to recover