#856  Automatic escaping of characters in secret during git sync
Released
Daniel Gollings opened 2 years ago

had a secret with character '/'

for example git push https://username:foo/bar@remoterepo.com

This character needs to be escaped/encoded: https://stackoverflow.com/a/59284165

so it becomes git push https://username:foo%2Fbar@remoterepo.com

fixed it by encoding the character manually and storing that as a secret. But should be very simple to automate. If you point me as to the where I could submit a PR for a simple search&replace (although tbh there's probably some better Java native URL encoder that needs to be called just before running the action)

Robin Shen commented 2 years ago

Thanks. I've fixed this at my side which is trivial.

Daniel Gollings commented 2 years ago

figured as much, but thought I'd offer :)

OneDev changed state to 'Closed' 2 years ago
Previous Value Current Value
Open
Closed
OneDev commented 2 years ago

State changed as code fixing the issue is committed

OneDev changed state to 'Released' 2 years ago
Previous Value Current Value
Closed
Released
OneDev commented 2 years ago

State changed as build #2899 is successful

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (4)
Reference
onedev/server#856
Please wait...
Page is in error, reload to recover