Daniel Gollings opened 2 years ago
|
|||||
The change is merged into main branch, but not released yet. Will be available in |
|||||
That's fine, thanks for letting me know. But what step was I missing when I tried to build it myself? Is there something 'special' for plugins? If I were to guess, upload/publish to Artifactory?
|
|||||
Make sure you are building against main branch instead of tag |
|||||
Run |
|||||
Weird, rebuilt it again on a new machine (after install Java 8) Ran:
SSHd it, restarted, same error Ok...
same thing, build, scp, deploy Works :) Guess something was being cached somewhere? |
|||||
Looks like the plugin jar is using old version from local maven repository. If running |
|||||
I may find the issue. After running I filed an improvement request to address this issue: issue #855 - Record commit in OneDev package and use this info to decide whether or not to upgrade |
|||||
thanks, on the one hand a very niche issue/bug. On the other, using a hash would be much better than a (I'm just assuming) simple string comparison. But good to hear you found a likely culprit
|
|||||
Robin Shen changed state to 'Closed' 2 years ago
|
|||||
Yes, will compare using the hash. Closing this now. |
Type |
Question
|
Priority |
Normal
|
Assignee |
Hi
Saw you merged pull request #48 and as far as I can tell released it in
7.4.17
But the error persists, and more interestingly, it refers to a line number which should be impossibleSeeing as line 23 is literally empty, I had the feeling that the plugin had not been updated.
So I built onedev myself (surprisingly easy, my compliments) and still received the same error. So for whatever reason its not building/updating that plugin? I checked out the manual (how to build a built in plugin) but looked good to me as far as I can tell.
Is there a missing step somewhere?