#771  Branch protection 分支保护 必须指定人?
Closed
dim opened 3 weeks ago

我设置了分支保护,必须要指定Required Reviewers 才能生效,否则的话还是可以提交。
这是设计的还是有点问题。

Robin Shen changed state to 'Closed' 3 weeks ago
Previous Value Current Value
Open
Closed
Robin Shen commented 3 weeks ago

分支保护有多层意思,即使不设置reviewer,也可以防止删除,防止覆盖等等。

dim commented 3 weeks ago

但是没设置人的话,还是可以随意提交的

Robin Shen commented 3 weeks ago

如果不设置人,至少可以防止覆盖和删除,这也是分支保护啊。如果你希望额外的审查,就加上人。这不矛盾啊。

dim commented 3 weeks ago

噢,是这个层次的意思,这个覆盖不是我想象的覆盖,👍

issue 1 of 1
Type
Discussion
Priority
Normal
Assignee
Issue Votes (0)
Watchers (4)
Reference
issue onedev/server#771
Please wait...
Page is in error, reload to recover