#747  Support verify signing with sub key
Released
Leslie Leung opened 2 years ago

I use a gpg subkey to sign my git commits, and on commit page it show a broken lock and prompt "Signature is signed with an unkown key (key ID: xxx)". I use the exact same key pair (the same subkey for signing and uploaded the same public key) on GitHub and it works well.

Upon looking at the source code, I found this logic below (io/onedev/server/git/GitUtils.java:678). It's clear that subkeys don't have the same keyId as the secret key, but the keyId of the subkeys should be included in the public key.

SignatureVerificationKey key = keyLoader.getSignatureVerificationKey(signature.getKeyID());
Leslie Leung commented 2 years ago

Also there is a typo on line 699, unkown should be unknown. @robin

OneDev changed state to 'Closed' 2 years ago
Previous Value Current Value
Open
Closed
OneDev commented 2 years ago

State changed as code fixing the issue is committed

OneDev changed state to 'Released' 2 years ago
Previous Value Current Value
Closed
Released
OneDev commented 2 years ago

State changed as build #2715 is successful

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Affected Versions
Not Found
Issue Votes (0)
Watchers (4)
Reference
onedev/server#747
Please wait...
Page is in error, reload to recover