onedev/server

#597 agent Failed to delete temp file on windows

Released

CaryTian opened 2 years ago

agent job build success, but it prompt faild to delete temp files

env: win11

server version: 6.3.7

agent version: download from server web.

Log:

21:46:41Step "build" is successful 21:46:43Error running job: java.util.concurrent.ExecutionException: java.lang.RuntimeException: Failed to delete file E:\onedev\agent\work\temp\onedev-build2525529665548307149\user at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at io.onedev.server.buildspec.job.JobExecution.check(JobExecution.java:52) at io.onedev.server.buildspec.job.DefaultJobManager$10.run(DefaultJobManager.java:1192) at io.onedev.server.persistence.DefaultTransactionManager$2.call(DefaultTransactionManager.java:103) at io.onedev.server.persistence.DefaultTransactionManager$2.call(DefaultTransactionManager.java:99) at io.onedev.server.persistence.DefaultTransactionManager$1.call(DefaultTransactionManager.java:72) at io.onedev.server.persistence.DefaultSessionManager.call(DefaultSessionManager.java:79) at io.onedev.server.persistence.DefaultTransactionManager.call(DefaultTransactionManager.java:60) at io.onedev.server.persistence.DefaultTransactionManager.run(DefaultTransactionManager.java:99) at io.onedev.server.buildspec.job.DefaultJobManager.run(DefaultJobManager.java:1141) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.RuntimeException: Failed to delete file E:\onedev\agent\work\temp\onedev-build2525529665548307149\user at io.onedev.commons.utils.FileUtils.deleteFile(FileUtils.java:235) at io.onedev.commons.utils.FileUtils.deleteDir(FileUtils.java:201) at io.onedev.commons.utils.FileUtils.cleanDir(FileUtils.java:290) at io.onedev.commons.utils.FileUtils.deleteDir(FileUtils.java:200) at io.onedev.agent.AgentSocket.executeShellJob(AgentSocket.java:453) at io.onedev.agent.AgentSocket.service(AgentSocket.java:898) at io.onedev.agent.AgentSocket.access$000(AgentSocket.java:100) at io.onedev.agent.AgentSocket$1.run(AgentSocket.java:202) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833)

Robin Shen commented 2 years ago

It works at my side. Can you please let me know how to get this reproduced?

CaryTian commented 2 years ago

Hi, @robin I found out that it is a problem with git for windows. New git has a feature called built-in file system watcher, It(git.exe) would occupy the source folders. So agent failed to delete.

Robin Shen commented 2 years ago

Thanks for the update. It really helps.

CaryTian changed state to 'Closed' 2 years ago

Previous Value	Current Value
Open	Closed

CaryTian commented 2 years ago

after disable git built-in file system watcher feature, solved.

Robin Shen commented 2 years ago

This issue will be fixed in next patch release, without the need to disable file system watcher feature.

OneDev changed state to 'Released' 2 years ago

Previous Value	Current Value
Closed	Released

OneDev commented 2 years ago

State changed as build #2335 is successful

Type	Bug
Priority	Normal
Assignee	Robin Shen
Affected Versions	Not Found

Issue Votes (0)

Watchers (4)

Reference

onedev/server#597