#235  Set the first day of week
Released
bufferUnderrun opened 3 years ago

Hi,

That's a minor feature but very frustrating so setting the first day of week in config could be great !

image.png

thanks

Robin Shen commented 3 years ago

What is the problem here?

bufferUnderrun commented 3 years ago

well,

The fact is sunday is the last day of week for a vast majority of countries and defined ISO 8601. Except for US and other metric system haters.

As sunday the last and so monday the first, it should be represented like this in a week calendar. I often make mistake selecting wrong day in datepicker due to this.

Change this setting in config would be very appreciated.

Robin Shen commented 3 years ago

I see. Thanks for the explanation.

Michael Weimann commented 3 years ago

Except for US and other metric system haters.

This sentence is a bit too offence imho.

Anyway I agree with bufferUnderrun. A locale setting for dates and other formats would be a nice feature.

Michael Weimann commented 3 years ago

Thinking more about that there should be a server setting with the default locale. An user should be able to override it. In addition to that per default the locale should be picked up by the browser settings.

Robin Shen commented 3 years ago

I agree that OneDev should detect locale from browser automatically. A server locale setting might not be very useful as different user may have different locale.

Robin Shen commented 3 years ago

The file date-picker.js contain the logic of calling flatpickr to display the date picker. We should be able to detect browser locale here and call with appropriate options.

Michael Weimann commented 3 years ago

I have just started implementing this: pull request onedev-server#25

OneDev changed state to 'Closed' 3 years ago
Previous Value Current Value
Open
Closed
OneDev changed state to 'Released' 3 years ago
Previous Value Current Value
Closed
Released
issue 1 of 1
Type
Improvement
Priority
Normal
Assignee
Issue Votes (0)
Watchers (3)
Reference
onedev/server#235
Please wait...
Page is in error, reload to recover