Order By
|
@robin this gets the project name instead of the project id, fix it and click on the log tab and it will download the log file instead of previewing the log file.
```java
Project project = OneDev.g...
Robin Shen
resolved 1 year ago
on file server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportDownloadResource.java
|
|
|
This variable always evaluated as empty in built image. I am testing the built image from ubuntu amd64.
Robin Shen
resolved 1 year ago
on file server-product/docker/entrypoint_agent.sh
|
|
|
Can we move the push logic out of build.sh like before? This way we can run build.sh locally to test the docker image without publishing to docker hub.
Robin Shen
resolved 1 year ago
on file server-product/docker/build.sh
|
|
|
Should be:
```suggestion
COPY entrypoint_agent.sh /agent/bin/entrypoint.sh
```
Otherwise agent can not be started.
Robin Shen
resolved 1 year ago
on file server-product/docker/Dockerfile.agent
|
|
|
This should be:
```suggestion
CMD ["/agent/bin/entrypoint.sh"]
```
Robin Shen
resolved 1 year ago
on file server-product/docker/Dockerfile.agent
|
|
|
OneDev does not ship any jdbc drivers in production build in order not to conflict with user downloaded versions.
Robin Shen
resolved 1 year ago
on file server-product/docker/build.sh
|
|
|
When running on Mac, this line reports error after build.sh finishes:
```
unknown shorthand flag: 'f' in -f ...
Robin Shen
resolved 1 year ago
on file server-product/docker/build.sh
|
|
|
We'd better move the logic of adding/removing ssh keys into SshKeyManager and protect it with a transaction to avoid partial updating.
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/security/OneAuthorizingRealm.java
|
|
|
Instead of overriding isVisible(), it is better to override onConfigure() and call setVisible. This is because isVisible() can be called multiple times in a single request. The same for other place...
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/page/admin/user/ssh/UserSshKeysPage.java
|
|
|
This should be changed to DefaultSshKeyManager
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultSshKeyManager.java
|
|
|
This can be deleted
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultSshKeyManager.java
|
|
|
This can also be deleted
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultSshKeyManager.java
|
|
|
This whole method should be protected with transaction by adding annotation @Transactional (from package _io.onedev.server.persistence.annotation_)
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultSshKeyManager.java
|
|
|
I'd suggest to set issue management of forked projects directly to false here even if parent project has issue management turned on, as forked projects normally uses parent project for issue tracking.
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/page/project/info/ForkOptionPanel.java
|
|
|
@robin I understand an empty value could be confusing but you've done this due to security reason and you were right !! Now, secrets are shown and so password, very bad to me. You should find anoth...
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java
|
|
|
We are already inside the DefaultSshKeyManager, so simplify the code block as below will be fine:
```
List<SshKey> currentKeys = loadUserKeys(user);
```
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultSshKeyManager.java
|
|
|
I wanted to iterate available locales and match them with the JS files available. But couldn't figure out how to do that. If you could give me a hint @robin ..
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/component/datepicker/DatePickerResourceReference.java
|
|
|
@robin do you know how Wicket works with locales? I thought the JS files will now only be loaded for the passed locale. That doesn't seem to be working.
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/component/datepicker/DatePickerResourceReference.java
|
|
|
@robin We get a NullPointerException here in our environment. I guess because of the linked query. https://code.onedev.io/projects/onedev-server/blob/17379d51fd037b74e2ee07547355f3d1036bffca/server...
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/security/permission/EditIssueField.java
|
|
|
@robin A sample code comment
Robin Shen
resolved 2 years ago
on file pom.xml
|
|
|
这里应该是6611
Robin Shen
resolved 2 years ago
on file server-product/helm/templates/service.yaml
|
|
|
@nex 改变作用域后，默认情况下这句不再返回True，导致不会包含默认的certmanager。
Robin Shen
resolved 2 years ago
on file server-product/helm/templates/ingress.yaml
|
|
|
@peter-jerry-ye 非常感谢。不过这里的中文字符以unicode方式存储，不太方便在IDE里编辑。你那边是怎么编辑的呢？
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage_zh.properties
|
|
|
This is a tricky one. I have to figure out how to provide the "db format" (`Y-m-d`) by the field while displaying another format.
Robin Shen
resolved 2 years ago
on file server-core/src/main/java/io/onedev/server/web/component/datepicker/date-picker.js
|
|
|
@alvin Why add retry count to namespace?
Robin Shen
resolved 2 years ago
on file server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java
|
|