• 2017-12-23
  • Merge pull request #56820 from ixdy/pure-go-binaries
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Bump rules_go and build "static" binaries in pure Go mode
    
    **What this PR does / why we need it**: uses latest set of enhancements in bazelbuild/rules_go to properly build the "static" Go binaries using pure Go (i.e. `CGO_ENABLED=0`), and to support cross compilation of these binaries. Cross compilation of cgo-enabled binaries is still not supported.
    
    Also depends on https://github.com/kubernetes/repo-infra/pull/52, and requires bazel 0.8+ (which is not yet enabled in CI for kubernetes/kubernetes).
    
    Note that for proper cross compilation we'll also need to remove the hardcoded "linux-amd64" that's strewn about several `BUILD` files.
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    
    /hold
    /assign @BenTheElder @mikedanese @spxtr
    master
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #55654 from stewart-yu/removeTODO
    Automatic merge from submit-queue (batch tested with PRs 57351, 55654). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    remove unnecessary TODO: Check ipvs version
    
    **What this PR does / why we need it**:
    Now that ipvs don't have version, this TODO no need.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57351 from nicksardo/auto-sub
    Automatic merge from submit-queue (batch tested with PRs 57351, 55654). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    GCE: Get automatically created subnetwork if none is specified for auto network
    
    Fixes #57350 
    
    **Release note**:
    ```release-note
    GCE: Fixes ILB creation on automatic networks with manually created subnetworks.
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57520 from nicksardo/update-gce
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Update vendor of google.golang.org/api repo
    
    Update vendor of GCE
    
    **Release note**:
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57513 from deads2k/admission-19-config
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    add eventratelimit config to scheme
    
    Fixes https://github.com/kubernetes/kubernetes/issues/57030
    
    Because the config types are decoded, their types have to be registered in the scheme used for admission config decoding.  Looks like we missed one.
    
    @kubernetes/sig-api-machinery-bugs 
    /assign jennybuckley
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #55669 from yuexiao-wang/apis-validate
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    add unit test for ValidateStatefulSet
    
    Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
    
    
    
    **What this PR does / why we need it**:
    add unit test for ValidateStatefulSetSpec
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57473 from spiffxp/add-code-of-conduct-to-staging-repos
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Add code-of-conduct.md to staging repos
    
    Instead of adding it directly to their published copies
    
    Replaces
    - https://github.com/kubernetes/api/pull/13
    - https://github.com/kubernetes/apiextensions-apiserver/pull/21
    - https://github.com/kubernetes/apimachinery/pull/33
    - https://github.com/kubernetes/apiserver/pull/28
    - https://github.com/kubernetes/client-go/pull/350
    - https://github.com/kubernetes/code-generator/pull/29
    - https://github.com/kubernetes/kube-aggregator/pull/11
    - https://github.com/kubernetes/metrics/pull/12
    - https://github.com/kubernetes/sample-apiserver/pull/18
    - https://github.com/kubernetes/sample-controller/pull/3
    
    ref: kubernetes/community#1527
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57573 from thockin/rollback-gcr-vanity
    Automatic merge from submit-queue (batch tested with PRs 57566, 57573). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Revert k8s.gcr.io vanity domain
    
    This reverts commit eba5b6092afcae27a7c925afea76b85d903e87a9 (#54174)
    
    Fixes https://github.com/kubernetes/kubernetes/issues/57526
    
    Will bring this back once we fix the SSL issue.
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57566 from bowei/expose-gce
    Automatic merge from submit-queue (batch tested with PRs 57566, 57573). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Expose all GCE cloud provider services versions, not just the GA API
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • 2017-12-22
  • Revert k8s.gcr.io vanity domain
    This reverts commit eba5b6092afcae27a7c925afea76b85d903e87a9.
    
    Fixes https://github.com/kubernetes/kubernetes/issues/57526
    Tim Hockin committed 6 years ago
  • Merge pull request #57564 from spiffxp/follow-gazelle-repo
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Handle gazelle moving to a new repo
    
    Gazelle moved to a new repo, and out of bazebuild/rules_go.  At first I tried the same approach I used for kubernetes/test-infra and just bumped to the new repo.  Turns out that version was later than what is used here in kubernetes/kubernetes.  Now I'm trying to use a rewritten version of `go_install_from_commit` to support installing packages that aren't available at HEAD
    
    ref kubernetes/test-infra#6075
    
    /priority critical-urgent
    https://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-verify is blocked until this is addressed
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Rewrite go_install_from_commit to handle pkgs that aren't in HEAD
    This is brittle and really only intended to workaround the fact that
    gazelle has moved out of the bazelbuild/rules_go repo to its own
    repo. I would rather see this reverted once we move to the same
    version of gazelle as used by kubernetes/test-infra
    Aaron Crickenberger committed 6 years ago
  • Merge pull request #57539 from vbmade2000/KUBEADM-WRONG-ERROR-MSG
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Correct wrong error message for kubeadm dns addon
    
    **What this PR does / why we need it**:
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #57538
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57207 from cimomo/kubeadm-fixes
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Improve error messages and comments in KubeAdm.
    
    **What this PR does / why we need it**:
    Improve error messages and comments in KubeAdm.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #56565 from stewart-yu/fixTextErrorKubeadm
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fix minor err in kubeadm
    
    **What this PR does / why we need it**:
    fix minor text error in kubeadm.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57358 from ericchiang/kubeadm-upgrade/unit-test-fix
    Automatic merge from submit-queue (batch tested with PRs 57139, 57358). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    kubeadm upgrade: fix unit test flake
    
    The CA generated for each test case is global and the cases modify
    the expiry. This can flake depending on what order the tests run.
    
    Generate a new CA for each test case.
    
    ```release-note
    NONE
    ```
    
    Fixes https://github.com/kubernetes/kubernetes/issues/57357
    
    /cc @kubernetes/sig-cluster-lifecycle-bugs 
    /cc @xiangpengzhao
    /cc @luxas
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57139 from bistros/master
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    fixed typo in kubeadm/v1alpha1/defaults.go
    
    **What this PR does / why we need it**:
    fixed some typo in comment
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57235 from xiangpengzhao/update-apps-ver
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Use apps/v1 API in kubeadm
    
    **What this PR does / why we need it**:
    The core workloads API has been promoted to GA stability in the apps/v1 group version from 1.9. Use apps/v1 API in kubeadm.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes https://github.com/kubernetes/kubeadm/issues/596
    
    **Special notes for your reviewer**:
    /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57541 from feiskyer/client
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Add generic interface for VirtualMachineScaleSetsClient
    
    **What this PR does / why we need it**:
    
    Add generic interface for VirtualMachineScaleSetsClient and VirtualMachineScaleSetVMsClient.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    
    Continue of #43287.
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    
    /assign @brendandburns @andyzhangx
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57387 from andyzhangx/add-owners
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    add Dong Liu as approver and add OWNERS in credentialprovider
    
    **What this PR does / why we need it**:
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #57540
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```
    none
    ```
    
    /sig azure
    /assign @brendandburns
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #56925 from wenjun93/fix_rbd
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    fix rbd volume ConstructVolumeSpec
    
    **What this PR does / why we need it**:
    1. rbd plugin.ConstructVolumeSpec() construct volume spec with fake value, cause kubelet volume manager will create two volumesInUse in node Status.
    2. change plugin.GetVolumeName(), create volumeName using rbd pool instead of monitors, because monitors is a group of IPs, which makes the volumeName too long. Also, this is to fit plugin.ConstructVolumeSpec() since makeGlobalPDName only uses rbd pool and image.
    
    ```
    before fix:
    volumesAttached:
      - devicePath: ""
        name: kubernetes.io/rbd/[xxxxxxx:6789 xxxxxxxxx:6789]:volume-9a106847-4def-4d1e-9603-4c7099b22a31
      volumesInUse:
      - 'kubernetes.io/rbd/[]:'
      - kubernetes.io/rbd/[xxxxxxx:6789 xxxxxxxxx:6789]:volume-9a106847-4def-4d1e-9603-4c7099b22a31
    
    after fix:
    volumesAttached:
      - devicePath: ""
        name: kubernetes.io/rbd/volumes:volume-9a106847-4def-4d1e-9603-4c7099b22a31
      volumesInUse:
      - kubernetes.io/rbd/volumes:volume-9a106847-4def-4d1e-9603-4c7099b22a31
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57392 from chrisglass/gke-spec-tweaks
    Automatic merge from submit-queue (batch tested with PRs 57532, 57392). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Gke spec tweaks
    
    **What this PR does / why we need it**:
    This PR removes two unnecessary requirements for the GKE node image validation spec:
    
    - The "vim" package doesn't need to be installed, as a vim environment is already available and the full "vim" pacakge installation takes some precious disk space.
    - The linux headers are not needed for the kubernetes node and cluster tests to succeed, and again, take unnecessary disk space.
    
    **Special notes for your reviewer**:
    None.
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57532 from mtaufen/fix-hyphen-dkcfg-test
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    dynamic config test: use a hyphen between the config name and the unique suffix
    
    These are painful to read right now due to the lack of hyphen.
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57476 from misterikkit/podAffinityNode
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Restrict pod affinity search when TopologyKey=kubernetes.io/hostname
    
    **What this PR does / why we need it**:
    
    When a PodAffinityTerm uses TopologyKey=kubernetes.io/hostname, we can avoid searching the entire cluster for a match by only listing pods on the given node.
    
    This is a set of 3 PRs targeting affinity predicate performance. (#57476, #57477, #57478) The key takeaway is approximately 2x speedup in the large affinity benchmark.
    
    The unexpected increase in BenchmarkScheduling/1000Nodes/1000Pods seems to be an outlier, and did not recur on subsequent runs. The benchmarks have a moderate amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    | test | b.N | master | #57476 | #57477 | #57478 | combined |
    | ---- | --- | ------ | ---------- | ---------- | ---------- | -------- |
    | BenchmarkScheduling/100Nodes/0Pods                | 100 |  39629010 ns/op | 36898566 ns/op (-6.89%)   |  38461530 ns/op (-2.95%)  |  36214136 ns/op (-8.62%)  |  43090781 ns/op (+8.74%)  |
    | BenchmarkScheduling/100Nodes/1000Pods             | 100 |  85489577 ns/op | 69538016 ns/op (-18.66%)  |  70104254 ns/op (-18.00%) |  75015585 ns/op (-12.25%) |  80986960 ns/op (-5.27%)  |
    | BenchmarkScheduling/1000Nodes/0Pods               | 100 | 219356660 ns/op | 200149051 ns/op (-8.76%)  | 192867469 ns/op (-12.08%) | 196896770 ns/op (-10.24%) | 212563662 ns/op (-3.10%)  |
    | BenchmarkScheduling/1000Nodes/1000Pods            | 100 | 380368238 ns/op | 381786369 ns/op (+0.37%)  | 387224973 ns/op (+1.80%)  | 417974358 ns/op (+9.89%)  | 411140230 ns/op (+8.09%)  |
    | BenchmarkSchedulingAntiAffinity/500Nodes/250Pods  | 250 | 124399176 ns/op | 97568988 ns/op (-21.57%)  | 112027363 ns/op (-9.95%)  | 129134326 ns/op (+3.81%)  |  98607941 ns/op (-20.73%) |
    | BenchmarkSchedulingAntiAffinity/500Nodes/5000Pods | 250 | 491677096 ns/op | 441562422 ns/op (-10.19%) | 278127757 ns/op (-43.43%) | 447355609 ns/op (-9.01%)  | 226310721 ns/op (-53.97%) |
    
    Combined performance contains all three patches.
    Percentages are relative to master.
    
    Methodology:
    
    I ran the tests on each branch with this command.
    ```
    make test-integration WHAT="./test/integration/scheduler_perf" KUBE_TEST_ARGS="-run=xxxx -bench=."
    ```
    
    The benchmarks have a fair amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    The three PRs in this set should collectively fix #54189.
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    Improve scheduler performance of MatchInterPodAffinity predicate.
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57488 from mtaufen/kc-bootstrap-refactor
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Refactor kubelet config controller bootstrap process
    
    This makes the bootstrap feel much more linear and as a result it is easier to read.
    
    Also simplifies status reporting for local config.
    
    Fixes: #57487
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Performance improvement for affinity term matching.
    When a PodAffinityTerm uses TopologyKey=kubernetes.io/hostname, we can
    avoid searching the entire cluster for a match by only listing pods on
    the given node.
    Jonathan Basseri committed 6 years ago
  • 2017-12-21
  • Refactor kubelet config controller bootstrap process
    This makes the bootstrap feel much more linear and as a result it is
    easier to read.
    
    Also simplifies status reporting for local config.
    Michael Taufen committed 6 years ago
  • Merge pull request #57477 from misterikkit/noStrCat
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Avoid string concatenation when comparing pods.
    
    **What this PR does / why we need it**:
    
    Pod comparison in (*NodeInfo).Filter was using GetPodFullName before
    comparing pod names. This is a concatenation of pod name and pod
    namespace, and it is significantly faster to compare name & namespace
    instead.
    
    This is a set of 3 PRs targeting affinity predicate performance. (#57476, #57477, #57478) The key takeaway is approximately 2x speedup in the large affinity benchmark.
    
    The unexpected increase in BenchmarkScheduling/1000Nodes/1000Pods seems to be an outlier, and did not recur on subsequent runs. The benchmarks have a moderate amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    | test | b.N | master | #57476 | #57477 | #57478 | combined |
    | ---- | --- | ------ | ------ | ---------- | ---------- | -------- |
    | BenchmarkScheduling/100Nodes/0Pods                | 100 |  39629010 ns/op | 36898566 ns/op (-6.89%)   |  38461530 ns/op (-2.95%)  |  36214136 ns/op (-8.62%)  |  43090781 ns/op (+8.74%)  |
    | BenchmarkScheduling/100Nodes/1000Pods             | 100 |  85489577 ns/op | 69538016 ns/op (-18.66%)  |  70104254 ns/op (-18.00%) |  75015585 ns/op (-12.25%) |  80986960 ns/op (-5.27%)  |
    | BenchmarkScheduling/1000Nodes/0Pods               | 100 | 219356660 ns/op | 200149051 ns/op (-8.76%)  | 192867469 ns/op (-12.08%) | 196896770 ns/op (-10.24%) | 212563662 ns/op (-3.10%)  |
    | BenchmarkScheduling/1000Nodes/1000Pods            | 100 | 380368238 ns/op | 381786369 ns/op (+0.37%)  | 387224973 ns/op (+1.80%)  | 417974358 ns/op (+9.89%)  | 411140230 ns/op (+8.09%)  |
    | BenchmarkSchedulingAntiAffinity/500Nodes/250Pods  | 250 | 124399176 ns/op | 97568988 ns/op (-21.57%)  | 112027363 ns/op (-9.95%)  | 129134326 ns/op (+3.81%)  |  98607941 ns/op (-20.73%) |
    | BenchmarkSchedulingAntiAffinity/500Nodes/5000Pods | 250 | 491677096 ns/op | 441562422 ns/op (-10.19%) | 278127757 ns/op (-43.43%) | 447355609 ns/op (-9.01%)  | 226310721 ns/op (-53.97%) |
    
    Combined performance contains all three patches.
    Percentages are relative to master.
    
    Methodology:
    
    I ran the tests on each branch with this command.
    ```
    make test-integration WHAT="./test/integration/scheduler_perf" KUBE_TEST_ARGS="-run=xxxx -bench=."
    ```
    
    The benchmarks have a fair amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    The three PRs in this set should collectively fix #54189.
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    Improve scheduler performance of MatchInterPodAffinity predicate.
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57490 from tianshapjq/cleanup-useless-func-pkg/client/conditions/conditions.go
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    cleanup useless functions and variables
    
    **What this PR does / why we need it**:
    cleanup useless functions and variables in pkg/client/conditions/conditions.go
    
    **Release note**:
    
    ```release-note
    
    ```NONE
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57478 from misterikkit/noArrayGrow
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Avoid array growth in FilteredList
    
    **What this PR does / why we need it**:
    
    The method (*schedulerCache).FilteredList builds an array of *v1.Pod
    that contains every pod in the cluster except for those filtered out by
    a predicate. Today, it starts with a nil slice and appends to it.
    
    Based on current usage, FilteredList is expected to return every pod in
    the cluster or omit some pods from a single node. This change reserves
    array capacity equal to the total number of pods in the cluster.
    
    This is a set of 3 PRs targeting affinity predicate performance. (#57476, #57477, #57478) The key takeaway is approximately 2x speedup in the large affinity benchmark.
    
    The unexpected increase in BenchmarkScheduling/1000Nodes/1000Pods seems to be an outlier, and did not recur on subsequent runs. The benchmarks have a moderate amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    | test | b.N | master | #57476 | #57477 | #57478 | combined |
    | ---- | --- | ------ | ------ | ------ | ---------- | -------- |
    | BenchmarkScheduling/100Nodes/0Pods                | 100 |  39629010 ns/op | 36898566 ns/op (-6.89%)   |  38461530 ns/op (-2.95%)  |  36214136 ns/op (-8.62%)  |  43090781 ns/op (+8.74%)  |
    | BenchmarkScheduling/100Nodes/1000Pods             | 100 |  85489577 ns/op | 69538016 ns/op (-18.66%)  |  70104254 ns/op (-18.00%) |  75015585 ns/op (-12.25%) |  80986960 ns/op (-5.27%)  |
    | BenchmarkScheduling/1000Nodes/0Pods               | 100 | 219356660 ns/op | 200149051 ns/op (-8.76%)  | 192867469 ns/op (-12.08%) | 196896770 ns/op (-10.24%) | 212563662 ns/op (-3.10%)  |
    | BenchmarkScheduling/1000Nodes/1000Pods            | 100 | 380368238 ns/op | 381786369 ns/op (+0.37%)  | 387224973 ns/op (+1.80%)  | 417974358 ns/op (+9.89%)  | 411140230 ns/op (+8.09%)  |
    | BenchmarkSchedulingAntiAffinity/500Nodes/250Pods  | 250 | 124399176 ns/op | 97568988 ns/op (-21.57%)  | 112027363 ns/op (-9.95%)  | 129134326 ns/op (+3.81%)  |  98607941 ns/op (-20.73%) |
    | BenchmarkSchedulingAntiAffinity/500Nodes/5000Pods | 250 | 491677096 ns/op | 441562422 ns/op (-10.19%) | 278127757 ns/op (-43.43%) | 447355609 ns/op (-9.01%)  | 226310721 ns/op (-53.97%) |
    
    Combined performance contains all three patches.
    Percentages are relative to master.
    
    Methodology:
    
    I ran the tests on each branch with this command.
    ```
    make test-integration WHAT="./test/integration/scheduler_perf" KUBE_TEST_ARGS="-run=xxxx -bench=."
    ```
    
    The benchmarks have a fair amount of variance to them, and I did not run them enough times to measure mean and standard deviation.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    The three PRs in this set should collectively fix #54189.
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    Improve scheduler performance of MatchInterPodAffinity predicate.
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #53557 from yolo3301/az_lb_pipid
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Allow use resource ID to specify public IP address in azure_loadbalancer
    
    **What this PR does / why we need it**: Currently the Azure load balancer assumes that a Public IP address is in the same resource group as the cluster. This is not necessarily true in all environments, in addition to accepting a Public IP, we should allow an annotation to the `Service` object that indicates what resource group the IP is present in.
    
    **Which issue this PR fixes**: fixes #53274 #52129
    
    **Special notes for your reviewer**: *first time golang user, please forgive the amateurness*
    
    Release note
    ```release-note
    Allow use resource ID to specify public IP address in azure_loadbalancer
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57101 from php-coder/local_up_cluster_daemon_msgs
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    local-up-cluster.sh: improve messages when running with ENABLE_DAEMON=true
    
    **What this PR does / why we need it**:
    Don't suggest to use `Ctrl+C` or open up another terminal when the script was running with `ENABLE_DAEMON=true`.
    
    **Release note**:
    ```release-note
    NONE
    ```
    
    CC @simo5
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Avoid array growth in FilteredList.
    The method (*schedulerCache).FilteredList builds an array of *v1.Pod
    that contains every pod in the cluster except for those filtered out by
    a predicate. Today, it starts with a nil slice and appends to it.
    
    Based on current usage, FilteredList is expected to return every pod in
    the cluster or omit some pods from a single node. This change reserves
    array capacity equal to the total number of pods in the cluster.
    Jonathan Basseri committed 6 years ago
  • Merge pull request #57296 from xiangpengzhao/update-coredns-corefile
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Update CoreDNS version and Corefile in kubeadm
    
    **What this PR does / why we need it**:
    We bumped CoreDNS version to 1.0.0 (#56802) and added CoreDNS as an optional addon in kube-up (#55728), but something wrt log was missed.  The log option of CoreDNS was changed since 1.0.0. We should update the Corefile to reflect the change.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes https://github.com/kubernetes/kubernetes/issues/57277
    
    ref: https://github.com/coredns/coredns/issues/1218 https://github.com/coredns/coredns/pull/1221
    
    **Special notes for your reviewer**:
    /cc @luxas @rajansandeep
    cc @fturib @johnbelamaric
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Avoid string concatenation when comparing pods.
    Pod comparison in (*NodeInfo).Filter was using GetPodFullName before
    comparing pod names. This is a concatenation of pod name and pod
    namespace, and it is significantly faster to compare name & namespace
    instead.
    Jonathan Basseri committed 6 years ago
  • Merge pull request #57192 from kawych/dashboard
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Reduce CPU request of Dashboard addon
    
    **What this PR does / why we need it**:
    This PR reduces request of Dashboard addon to free up cluster resources for user pods and other addons. Dashboard is bound on memory and under-utilizes CPU
    
    **Release note**:
    ```release-note
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57506 from tomerf/lb_typos
    Automatic merge from submit-queue (batch tested with PRs 57343, 57506). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fixed typos
    
    **What this PR does / why we need it**: Fixed typos
    
    **Which issue(s) this PR fixes** None
    
    **Special notes for your reviewer**: None
    
    **Release note**:
    /release-note-none
    Kubernetes Submit Queue committed with GitHub 6 years ago
  • Merge pull request #57343 from bskiba/cm-tests-two-containers
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Add custom metrics e2e test with two metrics.
    
    **What this PR does / why we need it**:
    Adds an e2e test for HPA, where a deployment is scaled based on two custom metrics.
    
    **Release note**:
    ```
    NONE
    ```
    Kubernetes Submit Queue committed with GitHub 6 years ago
Please wait...
Page is in error, reload to recover