• 2017-12-23
  • vm: allow modifying context name in inspector
    The `auxData` field is not exposed to JavaScript, as DevTools uses it
    for its `isDefault` parameter, which is implemented faithfully,
    contributing to the nice indentation in the context selection panel.
    Without the indentation, when `Target` domain gets implemented (along
    with a single Inspector for cluster) in #16627, subprocesses and VM
    contexts will be mixed up, causing confusion.
    
    PR-URL: https://github.com/nodejs/node/pull/17720
    Refs: https://github.com/nodejs/node/pull/14231#issuecomment-315924067
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    master
    Timothy Gu committed 6 years ago
  • 2017-12-22
  • test: do not open fixture files for writing
    Use temp directory for open with `O_DSYNC` (which indicates a write may
    occur) rather than `fixtures` directory. Additionally, test can be run
    on macOS so allow that in addition to Linux.
    
    PR-URL: https://github.com/nodejs/node/pull/17810
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Rich Trott committed 6 years ago
  • tools: fix man pages linking regex
    The change to word boundary was breaking many doc pages. This reverts
    the word boundary back to space.
    
    PR-URL: https://github.com/nodejs/node/pull/17724
    Fixes: https://github.com/nodejs/node/issues/17694
    Refs: https://github.com/nodejs/node/pull/17479
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Diego Rodríguez Baquero committed with Jon Moss 6 years ago
  • doc: fix links in errors.md
    PR-URL: https://github.com/nodejs/node/pull/17829
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Vse Mozhet Byt committed 6 years ago
  • deps: V8: cherry-pick ac0fe8ec from upstream
    Original commit message:
      [interpreter] Remove TryInstallOptimizedCode
    
      Removes the interrupt check and runtime call to TryInstallOptimizedCode
      from the optimization marker checks (i.e. CompileLazy and
      InterpreterEntryTrampoline). Instead, we rely on the other interrupt
      sources (in particular stack checks at function entries and loop
      headers) to install optimized code for us.
    
      This will hopefully not cause regressions, as we have plenty of other
      interrupt checks, but it may delay optimized code execution for
      some function by one function call.
    
      Bug:  v8:6933
      Change-Id: Ieadfff7ae2078d2a84085294158ad9a706eb9c64
      Reviewed-on: https://chromium-review.googlesource.com/723475
      Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48667}
    
    Ref: https://bugs.chromium.org/p/v8/issues/detail?id=6933
    Ref: https://github.com/v8/v8/commit/ac0fe8ec8a13493aba5fd7fe55220d23cee62562
    PR-URL: https://github.com/nodejs/node/pull/17695
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ali Ijaz Sheikh committed 6 years ago
  • http2: convert Http2Settings to an AsyncWrap
    PR-URL: https://github.com/nodejs/node/pull/17763
    Refs: https://github.com/nodejs/node/issues/17746
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    James M Snell committed 6 years ago
  • fs: move type checking to js
    PR-URL: https://github.com/nodejs/node/pull/17667
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    James M Snell committed 6 years ago
  • test: do not open fixture files for writing
    test-fs-fsync makes a copy of a fixture file, but then doesn't do
    anything with it and instead operates on the original fixture file. This
    appears to be in error, and this change fixes that.
    
    PR-URL: https://github.com/nodejs/node/pull/17808
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Rich Trott committed 6 years ago
  • repl: migrate errors to internal/errors
    PR-URL: https://github.com/nodejs/node/pull/17716
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    kysnm committed with Jon Moss 6 years ago
  • doc: removed extra explanation in api/buffer.md
    PR-URL: https://github.com/nodejs/node/pull/17796
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Waleed Ashraf committed with Jon Moss 6 years ago
  • deps: patch V8 to 6.3.292.48
    Refs: https://github.com/v8/v8/compare/6.3.292.46...6.3.292.48
    PR-URL: https://github.com/nodejs/node/pull/17773
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Myles Borins committed 6 years ago
  • crypto: warn on invalid authentication tag length
    PR-URL: https://github.com/nodejs/node/pull/17566
    Refs: https://github.com/nodejs/node/issues/17523
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Tobias Nießen committed 6 years ago
  • test: use valid authentication tag length
    Using authentication tags of invalid length does not conform to NIST
    standards.
    
    PR-URL: https://github.com/nodejs/node/pull/17566
    Refs: https://github.com/nodejs/node/issues/17523
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Tobias Nießen committed 6 years ago
  • doc: improve module.builtinModules documentation
    PR-URL: https://github.com/nodejs/node/pull/17712
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Thomas Watson committed with Jon Moss 6 years ago
  • tls: comment about old-style errors
    Old style errors are being migrated to internal/errors.js, however, due
    to depreciation of _tls_legacy.js, it isn't worth the effort to migrate
    and potentially force users to update their code for this error change.
    
    This comment clarifies the reason why this error is not migrated.
    
    PR-URL: https://github.com/nodejs/node/pull/17759
    Refs: https://github.com/nodejs/node/issues/17709
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    xortiz committed with Jon Moss 6 years ago
  • 2017-12-21
  • test: improve flaky test-listen-fd-ebadf.js
    Find an invalid file descriptor rather than assuming 42 will be invalid.
    
    PR-URL: https://github.com/nodejs/node/pull/17797
    Fixes: https://github.com/nodejs/node/issues/17762
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Rich Trott committed 6 years ago
  • test: refactor test-repl-definecommand
    The test was writing to both REPL input and output but only checking
    output. Sending output to both streams seems like it was an error.
    
    PR-URL: https://github.com/nodejs/node/pull/17795
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Rich Trott committed 6 years ago
  • src: remove redundant `JSStream::DoAfterWrite`
    `Finish<WriteWrap>` already does the same thing and is
    called immediately afterwards anyway.
    
    PR-URL: https://github.com/nodejs/node/pull/17713
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Anna Henningsen committed 6 years ago
  • test: fix buggy getTTYfd() implementation
    PR-URL: https://github.com/nodejs/node/pull/17781
    Ref: https://github.com/nodejs/node/pull/17781#discussion_r158030728
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Rich Trott committed 6 years ago
  • test: move firstInvalidFD() out of common module
    common.firstInvalidFD() is used in only one test. Move it out of the
    common module and into the one test that uses it.
    
    PR-URL: https://github.com/nodejs/node/pull/17781
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Rich Trott committed 6 years ago
  • test: remove getTTYfd() from common module
    common.getTTYfd() is used in one test only. Move it's definition to that
    test and out of the common module.
    
    PR-URL: https://github.com/nodejs/node/pull/17781
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Rich Trott committed 6 years ago
  • test: remove common.projectDir
    common.projectDir is used in one test, so it's not so common. Remove
    from common module to the one test file that needs it.
    
    PR-URL: https://github.com/nodejs/node/pull/17781
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Rich Trott committed 6 years ago
  • doc: warn about using util.inspect/util.format
    Because of the potential performance bottlenecks that may be introduced
    by `util.inspect()` and `util.format()` in production hot path code.
    
    Based on real user feedback, it is not obvious that these are intended
    to be debugging tools.
    
    PR-URL: https://github.com/nodejs/node/pull/17791
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    James M Snell committed 6 years ago
  • doc: instructions on how to make membership public
    PR-URL: https://github.com/nodejs/node/pull/17688
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Michael Dawson committed with Jon Moss 6 years ago
  • doc: improve fs api descriptions
    This improves the api descriptions for fs.chown, fs.chmod, and fs.mkdir
    along with their *Sync counterparts.
    
    PR-URL: https://github.com/nodejs/node/pull/17679
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Evan Lucas committed with Jon Moss 6 years ago
  • test: refactor test-net-connect-buffer
    - Use arrow functions, `common.mustCall()`
    - Remove redundant `console.log()`s/turn them into assertions
    - Use `common.expectsError()`
    
    PR-URL: https://github.com/nodejs/node/pull/17710
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Anna Henningsen committed with Jon Moss 6 years ago
  • test: increase diffie-hellman test coverage
    PR-URL: https://github.com/nodejs/node/pull/17728
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Leko committed with Jon Moss 6 years ago
  • repl: show lexically scoped vars in tab completion
    Use the V8 inspector protocol, if available, to query the list of
    lexically scoped variables (defined with `let`, `const` or `class`).
    
    PR-URL: https://github.com/nodejs/node/pull/16591
    Fixes: https://github.com/nodejs/node/issues/983
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Michaël Zasso committed 6 years ago
  • deps: cherry-pick 50f7455 from upstream V8
    Original commit message:
    
        [inspector] added Runtime.globalLexicalScopeNames method
    
        The method returns names for all available top-level scope variables
        in giving context.
    
        R=dgozman@chromium.org,jgruber@chromium.org
    
        Bug: chromium:681333
        Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
        Change-Id: I2d0b600e1afbfef9087f53ea9c26abe1e112047c
        Reviewed-on: https://chromium-review.googlesource.com/719409
        Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#48618}
    
    Refs: https://github.com/v8/v8/commit/50f7455cd973864fe70cc04f97146f725b7c3e54
    
    PR-URL: https://github.com/nodejs/node/pull/16591
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Michaël Zasso committed 6 years ago
  • test: increase pbkdf2 test coverage
    PR-URL: https://github.com/nodejs/node/pull/17730
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Leko committed with Tobias Nießen 6 years ago
  • net: remove ADDRCONFIG DNS hint on Windows
    On Windows setting ADDRCONFIG causes localhost resolution to fail if there are
    no network connections. This removes that flag on Windows.
    
    Fixes: https://github.com/nodejs/node/issues/17641
    PR-URL: https://github.com/nodejs/node/pull/17662
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Bartosz Sosnowski committed 6 years ago
  • util: fix custom inspect description
    Using a custom inspect function on the inspected object is
    deprecated. Remove the reference from the option description
    to make sure the user will read about the deprecation in the
    more detailed description.
    
    PR-URL: https://github.com/nodejs/node/pull/17576
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Ruben Bridgewater committed 6 years ago
  • util: rename util.inspect argument
    util.inspect can actually receive any property and the description
    was wrong so far. This fixes it by renaming the argument to
    value and also updating the description.
    
    PR-URL: https://github.com/nodejs/node/pull/17576
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Ruben Bridgewater committed 6 years ago
  • util: add util.inspect compact option
    The current default formatting is not ideal and this improves
    the situation by formatting the output more intuitiv.
    
    1) All object keys are now indented by 2 characters instead of
       sometimes 2 and sometimes 3 characters.
    2) Each object key will now use an individual line instead of
       sharing a line potentially with multiple object keys.
    3) Long strings will now be split into multiple lines in case
       they exceed the "lineBreak" option length (including the
       current indentation).
    4) Opening braces are now directly behind a object property
       instead of using a new line.
    5) Switch inspect "base" order. In case the compact option is set
       to `false`, inspect will now print
         "[Function: foo] {\n  property: 'data'\n}"
       instead of
         "{ [Function: foo]\n  property: 'data'\n}".
    
    PR-URL: https://github.com/nodejs/node/pull/17576
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Ruben Bridgewater committed 6 years ago
  • assert: .throws accept objects
    From now on it is possible to use a validation object in throws
    instead of the other possibilites.
    
    PR-URL: https://github.com/nodejs/node/pull/17584
    Refs: https://github.com/nodejs/node/pull/17557
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Ruben Bridgewater committed 6 years ago
  • 2017-12-20
  • http2: use session kUpdateTimer from kUpdateTimer
    Reduces duplicated logic.
    
    PR-URL: https://github.com/nodejs/node/pull/17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Jeremiah Senkpiel committed 6 years ago
  • http2: use actual Timeout instances
    This makes `Http2Stream`s and `Http2Session`s use actual Timeout
    objects in a [kTimeout] symbol property, rather than making the
    stream/session itself a timer and appending properties to it directly.
    
    PR-URL: https://github.com/nodejs/node/pull/17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Jeremiah Senkpiel committed 6 years ago
  • timers: extract enroll() validation into a fn
    This should help keep everything consistent.
    
    PR-URL: https://github.com/nodejs/node/pull/17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Jeremiah Senkpiel committed 6 years ago
  • net: use actual Timeout instance on Sockets
    This makes `net.Sockets` use actual Timeout objects in a `[kTimeout]`
    symbol property, rather than making the socket itself a timer and
    appending properties to it directly.
    
    This should make the code generally easier to understand, and might
    also prevent some deopts from properties being changes on the socket
    itself.
    
    Also moves the Timeout constructor into an internal module.
    
    PR-URL: https://github.com/nodejs/node/pull/17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Jeremiah Senkpiel committed 6 years ago
  • test: fix typo in test-inspector-cluster-port-clash.js
    PR-URL: https://github.com/nodejs/node/pull/17782
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Rich Trott committed 6 years ago
  • crypto: reuse variable instead of reevaluation
    PR-URL: https://github.com/nodejs/node/pull/17735
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Tobias Nießen committed 6 years ago
  • events: add off alias to removeListener
    Add `off` as an alias for `removeListener`
    
    PR-URL: https://github.com/nodejs/node/pull/17156
    Refs: https://github.com/nodejs/node/issues/17102
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Ulmanb committed with Benjamin Gruenbaum 6 years ago
  • src: remove unused async hooks methods
    PR-URL: https://github.com/nodejs/node/pull/17757
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: vdeturckheim <vlad2t@hotmail.com>
    Anna Henningsen committed 6 years ago
  • doc: remove old console note
    This should not be important anymore in newer docs. The change is
    also documented in the "changed" part of the function.
    
    PR-URL: https://github.com/nodejs/node/pull/17707
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ruben Bridgewater committed 6 years ago
  • console: order functions and remove \n\n
    This lists all function aliases directly below the declared function.
    
    PR-URL: https://github.com/nodejs/node/pull/17707
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ruben Bridgewater committed 6 years ago
  • benchmark: refactor console benchmark
    Fix and refactor the console benchmark. It did not test console
    so it got renamed and mainly tests the different ways of passing
    arguments through.
    
    PR-URL: https://github.com/nodejs/node/pull/17707
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ruben Bridgewater committed 6 years ago
  • console: make variables and checks stricter
    PR-URL: https://github.com/nodejs/node/pull/17707
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ruben Bridgewater committed 6 years ago
  • console: make error handling engine agnostic
    Calling write could throw a maximum call stack size error. To make
    sure this is not specific to a single engine (version), lazily
    populate the correct error message by producing such a error on
    demand.
    
    PR-URL: https://github.com/nodejs/node/pull/17707
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Ruben Bridgewater committed 6 years ago
  • http2: simplify onSelectPadding
    `OnCallbackPadding` on the native side already clamps
    the return value into the right range, so there’s not need
    to also do that on the JS side.
    
    Also, use `>>> 0` instead of `| 0` to get an uint32, since
    the communication with C++ land happens through an Uint32Array.
    
    PR-URL: https://github.com/nodejs/node/pull/17717
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Anna Henningsen committed with James M Snell 6 years ago
  • http2: refactor outgoing write mechanism
    - Only finish outgoing `WriteWrap`s once data has actually been
      passed to the underlying socket.
      - This makes HTTP2 streams respect backpressure
    - Use `DoTryWrite` as a shortcut for sending out as much of
      the data synchronously without blocking as possible
    - Use `NGHTTP2_DATA_FLAG_NO_COPY` to avoid copying DATA frame
      contents into nghttp2’s buffers before sending them out.
    
    PR-URL: https://github.com/nodejs/node/pull/17718
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Anna Henningsen committed with James M Snell 6 years ago
Please wait...
Page is in error, reload to recover