Commits were merged into target branch
|
Michael Weimann opened 4 years ago
|
||||
|
New commits added 4 years ago
|
|||||
|
|||||
|
Great job. Added some code comments. |
||||
|
New commits added 4 years ago
|
|||||
|
|
@robin I think I have done all tasks. Please review again. Thanks for the support. |
||||
|
|
@mweimann checked the code and the whole logic is very complete, 👍 Added Some minor code suggestions though. |
||||
|
New commits added 4 years ago
|
|||||
|
|
Comments done ✓ |
||||
|
New commits added 4 years ago
|
|||||
|
|
Robin Shen approved 4 years ago
|
||||
|
|
OneDev merged 4 years ago
|
||||
|
|
Michael Weimann changed title 4 years ago
|
| Submitter | Michael Weimann |
| Target | master |
| Source | onedev-server.mweimann:feature/102-ldap-ssh-public-keys |
Reviewers
Merge Strategy
Create Merge Commit
Watchers (4)
Please do not merge yet - Work in progress!
Here is my work so far. Tested against my LDAP - basically works.
I hope the error handling is okay.
Please see my code comments.
Closes issue #102