#59  fix: can't use SSO to log in with new user
Discarded
This pull request has been discarded
knard opened 6 months ago

When new user is persisted the application try to reload the actual page which lead to a failure. The OAuth2 process will be trigger directly to the callback page that lead to failure. The page is reloaded because the session is cleaned for security reason.

Just after the session cleaning a value is set to avoid triggering the authentication process again.

New commits added 6 months ago
fix: can't use SSO to log in with new user
When new user is persisted the application try to reload the actual
page which lead to a failure. The OAuth2 process will be trigger
directly to the callback page that lead to failure. The page is reloaded
because the session is cleaned for security reason.

Just after the session cleaning a value is set to avoid triggering the
authentication process again.
Robin Shen commented 6 months ago

This is actually a bug caused by a recent commit (not released yet), and has been fixed in commit cf75ec69. This pull request is no longer necessary. Thanks for bringing this into attention though.

knard commented 6 months ago

Ok, I'll discard the merge. With your fix everything is working fine now.

knard discarded 6 months ago
knard commented 6 months ago

not needed anymore. fix has been provided in different way.

pull request 1 of 1
Submitter knard
Target main
Source knard/server:fix_sso
Assignees
Merge Strategy
Create Merge Commit
Watchers (4)
Reference
pull request onedev/server#59
Please wait...
Page is in error, reload to recover